Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor in prep for release #58

Merged
merged 11 commits into from
Jan 18, 2022
Merged

Refactor in prep for release #58

merged 11 commits into from
Jan 18, 2022

Conversation

blackfalcon
Copy link
Member

@blackfalcon blackfalcon commented Jan 12, 2022 •
edited
Loading

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: See 'linked issues'

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

This PR will address a number of issues within the scope of preparing this repo for release. See individual commits for additional details.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@blackfalcon blackfalcon self-assigned this Jan 12, 2022
@blackfalcon
refactor(styles): address naming conventions to style files #52
cd3e934 
There are a lot of files in the ./src directory, this commit updates
the names of those files to make it more clear as to what files they are
and what they are used for.

style.scss was renamed to style-base.scss as a simple fix to a
postCss problem.

Changes to be committed:
modified:   docs/api.md
modified:   src/auro-menu-option.js
modified:   src/auro-menu.js
modified:   src/auro-sub-menu.js
renamed:    src/style-fixed.scss -> src/style-base-fixed.scss
renamed:    src/style.scss -> src/style-base.scss
renamed:    src/auro-menu-option-fixed.scss -> src/style-menu-option-fixed.scss
renamed:    src/auro-menu-option.scss -> src/style-menu-option.scss
renamed:    src/auro-sub-menu-fixed.scss -> src/style-sub-menu-fixed.scss
renamed:    src/auro-sub-menu.scss -> src/style-sub-menu.scss
@blackfalcon
refactor(isHidden): remove attribute #52
983cfbb 
Changes to be committed:
modified:   demo/demo.md
modified:   docs/api.md
modified:   src/auro-menu-option.js
modified:   src/auro-menu.js
@blackfalcon
refactor(indexSelectedOption): update to use element value
ed78bdb 
Changes to be committed:
modified:   src/auro-menu.js
@jason-capsule42
Copy link
Member

The branch fails to run for me.

[0] TypeError: Cannot read property 'nodes' of undefined [0] at l (/Users/jasonbaker/Development/AlaskaAir/AlaskaAirlines/auro-menu/node_modules/postcss-custom-properties/dist/index.cjs:1:644) [0] at Object.prepare (/Users/jasonbaker/Development/AlaskaAir/AlaskaAirlines/auro-menu/node_modules/postcss-custom-properties/dist/index.cjs:1:5256) [0] at /Users/jasonbaker/Development/AlaskaAir/AlaskaAirlines/auro-menu/node_modules/postcss/lib/lazy-result.js:149:39 [0] at Array.map (<anonymous>) [0] at new LazyResult (/Users/jasonbaker/Development/AlaskaAir/AlaskaAirlines/auro-menu/node_modules/postcss/lib/lazy-result.js:147:43) [0] at Processor.process (/Users/jasonbaker/Development/AlaskaAir/AlaskaAirlines/auro-menu/node_modules/postcss/lib/processor.js:28:14) [0] at /Users/jasonbaker/Development/AlaskaAir/AlaskaAirlines/auro-menu/scripts/postCss.js:65:6 [0] at FSReqCallback.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:71:3) [0] npm notice [0] npm notice New major version of npm available! 7.24.2 -> 8.3.0 [0] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.3.0> npm notice Run npm install -g [email protected]to update! [0] npm notice [0] ERROR: "postCss:component" exited with 1. [0] npm notice [0] npm notice New major version of npm available! 7.24.2 -> 8.3.0 [0] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.3.0> [0] npm notice Runnpm install -g [email protected] to update! [0] npm notice [0] [nodemon] app crashed - waiting for file changes before starting...

jason-capsule42
jason-capsule42 requested changes Jan 13, 2022
View reviewed changes
src/auro-menu-option.js Outdated Show resolved Hide resolved
src/auro-menu-option.js Outdated Show resolved Hide resolved
src/auro-menu-option.js Outdated Show resolved Hide resolved
src/auro-menu.js Outdated Show resolved Hide resolved
@blackfalcon
perf(icon): update to support direct dependency with icon
00fc782 
Changes to be committed:
modified:   demo/demo.md
modified:   demo/index.html
modified:   package.json
modified:   src/auro-menu-option.js
@blackfalcon
refactor(ie): remove webcomponentsjs legacy browser support
603c811 
Changes to be committed:
modified:   package.json
@blackfalcon
refactor(listOfOptions): remove unnecessary slot name convention #52
f4d03f4 
Changes to be committed:
modified:   demo/demo.md
modified:   src/auro-menu.js
modified:   test/auro-menu.test.js
@blackfalcon blackfalcon force-pushed the dsande/apireview/#52 branch 3 times, most recently from a848e33 to 6b430b4 Compare January 16, 2022 04:23
@blackfalcon
refactor(style): simplify checkmark ui #52
fb864c8 
Changes to be committed:
modified:   demo/demo.md
modified:   docs/api.md
modified:   src/auro-menu-option.js
modified:   src/auro-menu.js
modified:   src/style-base.scss
modified:   src/style-menu-option.scss
modified:   src/style-sub-menu.scss
@blackfalcon blackfalcon linked an issue Jan 16, 2022 that may be closed by this pull request
Complete code and API review by dev team lead #52
Closed
@blackfalcon
refactor(indexSelectedOption): redefine comment; update demo
136d69a 
Changes to be committed:
modified:   demo/demo.md
modified:   src/auro-menu.js
@blackfalcon
Copy link
Member Author

The branch fails to run for me.

[0] TypeError: Cannot read property 'nodes' of undefined [0] at l ...

Try running npm ci and be sure you are on node 16.x.

@blackfalcon
refactor(unused api): remove unused api references from code
50da940 
Changes to be committed:
modified:   docs/api.md
modified:   src/auro-menu-option.js
modified:   src/auro-menu.js
modified:   src/auro-sub-menu.js
@blackfalcon blackfalcon mentioned this pull request Jan 18, 2022
Closed
@blackfalcon blackfalcon marked this pull request as ready for review January 18, 2022 20:30
@blackfalcon blackfalcon requested a review from a team as a code owner January 18, 2022 20:30
@blackfalcon blackfalcon linked an issue Jan 18, 2022 that may be closed by this pull request
Hover and selected state #56
Closed
@blackfalcon
refactor(menu): remove attributeChangedCallback function #59
0db6159 
Changes to be committed:
modified:   src/auro-menu.js
This was linked to issues Jan 18, 2022
attributeChangedCallback is not doing anything? #59
Closed
Why is a mouseover event needed? #61
Closed
How does this 'inject a checkmark'? #63
Closed
@blackfalcon
refactor(menu): prevent default on browser scroll #62
4faa2ec 
Changes to be committed:
modified:   src/auro-menu.js
@blackfalcon blackfalcon linked an issue Jan 18, 2022 that may be closed by this pull request
Prevent default #62
Closed
jason-capsule42
jason-capsule42 requested changes Jan 18, 2022
View reviewed changes
src/style-sub-menu.scss Show resolved Hide resolved
src/auro-menu.js Show resolved Hide resolved
docs/api.md Show resolved Hide resolved
@jason-capsule42
Copy link
Member

The branch fails to run for me.
[0] TypeError: Cannot read property 'nodes' of undefined [0] at l ...

Try running npm ci and be sure you are on node 16.x.

Turns out this came from having .map files left behind from doing a build on a previous version of the generator.

@jason-capsule42 jason-capsule42 self-requested a review January 18, 2022 22:04
@blackfalcon blackfalcon merged commit d050daa into v3.0-rc Jan 18, 2022
@blackfalcon blackfalcon deleted the dsande/apireview/#52 branch January 18, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-capsule42 jason-capsule42 jason-capsule42 approved these changes

Assignees

@blackfalcon blackfalcon

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@blackfalcon @jason-capsule42