Refactor to use value versus data-value on menu option #80
+153
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to be committed: modified: docs/api.md modified: src/auro-menu.js modified: src/auro-menuoption.js modified: test/auro-menu.test.js
Changes to be committed: modified: demo/demo.md modified: demo/partials/default.html modified: demo/partials/disabled.html modified: demo/partials/hr.html modified: demo/partials/preselect.html modified: demo/partials/restrictedWidth.html
blackfalcon
force-pushed
the
dsande/datavalue/#65
branch
from
e0c6d35 to
9795af6
Compare
jason-capsule42
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #65
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
The scope of this PR is to refactor
auro-menuto use a strictvalueversus the contriveddata-valueattribute from the menu option.When this version is released, this will require
auro-dropdownmenuto update its demo. This work was tested with the current version ofauro-dropdownmenuto ensure compatibility.Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team