New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the concept of data-value #65

Closed

blackfalcon opened this issue Jan 13, 2022 · 1 comment · Fixed by #80

Assignees

Labels

auro-menu Type: Feature

Milestone

auro-menu v3.1-rc

Member

blackfalcon commented Jan 13, 2022

With a traditional combo box select menu the option element has a value attr,

<option value="volvo">Volvo</option>

I'd like to revisit this data-value feature and see if we can refactor this to be more like a native element.

auro-menu/src/auro-menu.js

Lines 49 to 60 in 983cfbb

    
           handleSlotChange() { 
        
             const dispatchEventOptionSelected = (indexValue, dataValue, displayText) => { 
        
               this.dispatchEvent(new CustomEvent('optionSelected', { 
        
                 bubbles: true, 
        
                 cancelable: false, 
        
                 composed: true, 
        
                 detail: { 
        
                   index: indexValue, 
        
                   value: dataValue, 
        
                   displayText, 
        
                 } 
        
               }));

The text was updated successfully, but these errors were encountered:

blackfalcon added Type: Refactoring auro-menu labels

blackfalcon added this to the auro-menu v3.0-rc milestone

blackfalcon self-assigned this

braven112 modified the milestones: auro-menu v3.0-rc, auro-menu v3.1-rc

blackfalcon added the Status: Work In Progress label

settings bot removed the Type: Refactoring label

blackfalcon added a commit that referenced this issue


          refactor(data-value): update to use direct value attr #65

bc842bc

Changes to be committed:
modified:   docs/api.md
modified:   src/auro-menu.js
modified:   src/auro-menuoption.js
modified:   test/auro-menu.test.js

blackfalcon added a commit that referenced this issue


          docs(demo): update to reflect new dom changes #65

ae01879

Changes to be committed:
modified:   demo/demo.md
modified:   demo/partials/default.html
modified:   demo/partials/disabled.html
modified:   demo/partials/hr.html
modified:   demo/partials/preselect.html
modified:   demo/partials/restrictedWidth.html

blackfalcon added a commit that referenced this issue


          refactor(data-value): update to use direct value attr #65

4e263e5

Changes to be committed:
modified:   docs/api.md
modified:   src/auro-menu.js
modified:   src/auro-menuoption.js
modified:   test/auro-menu.test.js

blackfalcon added a commit that referenced this issue


          docs(demo): update to reflect new dom changes #65

e0c6d35

Changes to be committed:
modified:   demo/demo.md
modified:   demo/partials/default.html
modified:   demo/partials/disabled.html
modified:   demo/partials/hr.html
modified:   demo/partials/preselect.html
modified:   demo/partials/restrictedWidth.html

blackfalcon mentioned this issue

Refactor to use value versus data-value on menu option #80

Merged

6 tasks

blackfalcon linked a pull request

that will close this issue

Refactor to use value versus data-value on menu option #80

Merged

6 tasks

blackfalcon added Type: Feature and removed Status: Work In Progress labels

blackfalcon added a commit that referenced this issue


          refactor(data-value): update to use direct value attr #65

a8a184c

Changes to be committed:
modified:   docs/api.md
modified:   src/auro-menu.js
modified:   src/auro-menuoption.js
modified:   test/auro-menu.test.js

blackfalcon added a commit that referenced this issue


          docs(demo): update to reflect new dom changes #65

9795af6

Changes to be committed:
modified:   demo/demo.md
modified:   demo/partials/default.html
modified:   demo/partials/disabled.html
modified:   demo/partials/hr.html
modified:   demo/partials/preselect.html
modified:   demo/partials/restrictedWidth.html

blackfalcon mentioned this issue

Tab into radio group handles disabled groups differently AlaskaAirlines/auro-radio#47

Closed

blackfalcon added a commit that referenced this issue


          refactor(data-value): update to use direct value attr #65

6c962a8

Changes to be committed:
modified:   docs/api.md
modified:   src/auro-menu.js
modified:   src/auro-menuoption.js
modified:   test/auro-menu.test.js

blackfalcon added a commit that referenced this issue


          docs(demo): update to reflect new dom changes #65

88b38dc

Changes to be committed:
modified:   demo/demo.md
modified:   demo/partials/default.html
modified:   demo/partials/disabled.html
modified:   demo/partials/hr.html
modified:   demo/partials/preselect.html
modified:   demo/partials/restrictedWidth.html

blackfalcon linked a pull request

that will close this issue

a11y review and functional refactor #81

Merged

6 tasks

blackfalcon added Status: Work In Progress and removed Status: Work In Progress labels

Member Author

blackfalcon commented Feb 2, 2022

Oops my bad... this work is completed and merged in with #80

blackfalcon closed this as completed

blackfalcon removed a link to a pull request

a11y review and functional refactor #81

Merged

6 tasks

blackfalcon added a commit that referenced this issue


          refactor(data-value): update to use direct value attr #65

d5d9ae7

Changes to be committed:
modified:   docs/api.md
modified:   src/auro-menu.js
modified:   src/auro-menuoption.js
modified:   test/auro-menu.test.js

blackfalcon added a commit that referenced this issue


          docs(demo): update to reflect new dom changes #65

8193e93

Changes to be committed:
modified:   demo/demo.md
modified:   demo/partials/default.html
modified:   demo/partials/disabled.html
modified:   demo/partials/hr.html
modified:   demo/partials/preselect.html
modified:   demo/partials/restrictedWidth.html

blackfalcon added a commit that referenced this issue


          refactor(data-value): update to use direct value attr #65

8baac47

Changes to be committed:
modified:   docs/api.md
modified:   src/auro-menu.js
modified:   src/auro-menuoption.js
modified:   test/auro-menu.test.js

blackfalcon added a commit that referenced this issue


          docs(demo): update to reflect new dom changes #65

52487c2

Changes to be committed:
modified:   demo/demo.md
modified:   demo/partials/default.html
modified:   demo/partials/disabled.html
modified:   demo/partials/hr.html
modified:   demo/partials/preselect.html
modified:   demo/partials/restrictedWidth.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment