Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color tokens for theming support #63

Closed
2 tasks
jordanjones243 opened this issue Mar 13, 2024 · 2 comments · Fixed by #72 or #77
Closed
2 tasks

Update color tokens for theming support #63

jordanjones243 opened this issue Mar 13, 2024 · 2 comments · Fixed by #72 or #77
Assignees

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Mar 13, 2024

General Support Request

In order to make Auro components themeable, we need to make sure there are no hard-coded and correct semanticly named tokens within the component. There also needs to be investigation around border rules which have a combination of size and color tokens, making them more complex, as well as background-color and color rules.

Possible Solution

Work with designers to figure out what tokens need updated values or renamed.

Additional context

This work stems from theming work happening to all Auro components:

Rules and tokens to be edited can be found in the comments.

Acceptance Criteria:

  • All tier 3 token names have been implemented.
  • Colors identified below have been updated to their tier 3 token name.
@jordanjones243
Copy link
Contributor Author

  • Hardcoded
    • Box-shadow: -2px 0 5px 2px rgba(0, 0, 0, .08) 0 2px 5px 1px rgba(0, 0, 0, .08);
  • Tier 1
    • Arrow pseudo element background color: var(--ds-color-base-white, $ds-color-base-white);
    • Arrow pseudo element box shadow: box-shadow: 2px 2px 1px 0 rgba(0, 0, 0, .08);

@blackfalcon blackfalcon added Type: Refactoring A code change that neither fixes a bug nor adds a feature auro-popover Type: Perf Performance update to existing code labels Mar 21, 2024
@jordanjones243 jordanjones243 mentioned this issue May 31, 2024
9 tasks
@jordanjones243 jordanjones243 linked a pull request May 31, 2024 that will close this issue
9 tasks
blackfalcon pushed a commit that referenced this issue Jul 1, 2024
# [3.3.0-beta.1](v3.2.3...v3.3.0-beta.1) (2024-07-01)

### Features

* refactor color token structure with tier 3 tokens [#63](#63) ([e5a59fd](e5a59fd))

### Performance Improvements

* replace hardcoded size values with design tokens ([2c3c68d](2c3c68d))
@jordanjones243 jordanjones243 linked a pull request Jul 8, 2024 that will close this issue
6 tasks
@jordanjones243 jordanjones243 linked a pull request Aug 16, 2024 that will close this issue
6 tasks
@jordanjones243
Copy link
Contributor Author

jordanjones243 commented Sep 19, 2024

Need design to revise the semantic tokens being used within the tokens.scss file. @leeejune

jordanjones243 added a commit that referenced this issue Sep 27, 2024
BREAKING CHANGE: trigger major release for color theme support #63
jordanjones243 added a commit that referenced this issue Sep 30, 2024
BREAKING CHANGE: trigger major release for color theme support #63
blackfalcon pushed a commit that referenced this issue Sep 30, 2024
# [4.0.0-beta.1](v3.3.0-beta.3...v4.0.0-beta.1) (2024-09-30)

### Bug Fixes

* resolve minor color theming issues ([89b344a](89b344a))

### Performance Improvements

* refactor custom component registration config ([d080c60](d080c60))
* update dependencies ([74ab81a](74ab81a))

### BREAKING CHANGES

* trigger major release for color theme support #63
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
# [3.3.0-beta.1](v3.2.3...v3.3.0-beta.1) (2024-07-01)

### Features

* refactor color token structure with tier 3 tokens [#63](#63) ([e5a59fd](e5a59fd))

### Performance Improvements

* replace hardcoded size values with design tokens ([2c3c68d](2c3c68d))
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
BREAKING CHANGE: trigger major release for color theme support #63
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
# [4.0.0-beta.1](v3.3.0-beta.3...v4.0.0-beta.1) (2024-09-30)

### Bug Fixes

* resolve minor color theming issues ([89b344a](89b344a))

### Performance Improvements

* refactor custom component registration config ([d080c60](d080c60))
* update dependencies ([74ab81a](74ab81a))

### BREAKING CHANGES

* trigger major release for color theme support #63
blackfalcon pushed a commit that referenced this issue Sep 30, 2024
# [4.0.0](v3.2.3...v4.0.0) (2024-09-30)

### Bug Fixes

* **popover:** update styles to reconfigure trigger and box-shadow ([6228987](6228987))
* resolve minor color theming issues ([f547a63](f547a63))

### Features

* refactor color token structure with tier 3 tokens [#63](#63) ([e9906cf](e9906cf))

### Performance Improvements

* refactor custom component registration config ([083e22c](083e22c))
* replace hardcoded size values with design tokens ([ae404c3](ae404c3))
* update dependencies ([8c81954](8c81954))
* update deps and add name as attribute when custom registered ([100e6cc](100e6cc))

### BREAKING CHANGES

* trigger major release for color theme support #63
@jason-capsule42 jason-capsule42 removed Type: Refactoring A code change that neither fixes a bug nor adds a feature Type: Perf Performance update to existing code labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment