Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move theming support from Beta to Main #77

Merged
merged 15 commits into from
Sep 30, 2024
Merged

Move theming support from Beta to Main #77

merged 15 commits into from
Sep 30, 2024

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Aug 16, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #63

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Move theming support for the popover component from beta to main, enabling customization through design tokens. Refactor the component to replace hardcoded size and color values with design tokens, and update documentation to guide users on restyling the component.

New Features:

  • Introduce theming support for the popover component, allowing customization through design tokens.

Enhancements:

  • Refactor the popover component to use design tokens for size and color values, replacing hardcoded values.

Documentation:

  • Add documentation on how to restyle the popover component using design tokens.

jordanjones243 and others added 9 commits July 1, 2024 09:29
# [3.3.0-beta.1](v3.2.3...v3.3.0-beta.1) (2024-07-01)

### Features

* refactor color token structure with tier 3 tokens [#63](#63) ([e5a59fd](e5a59fd))

### Performance Improvements

* replace hardcoded size values with design tokens ([2c3c68d](2c3c68d))
# [3.3.0-beta.2](v3.3.0-beta.1...v3.3.0-beta.2) (2024-08-09)

### Bug Fixes

* **popover:** update styles to reconfigure trigger and box-shadow ([b771780](b771780))
# [3.3.0-beta.3](v3.3.0-beta.2...v3.3.0-beta.3) (2024-08-15)

### Performance Improvements

* update deps and add name as attribute when custom registered ([e5ceef4](e5ceef4))
@jordanjones243 jordanjones243 self-assigned this Aug 16, 2024
@jordanjones243 jordanjones243 linked an issue Aug 16, 2024 that may be closed by this pull request
2 tasks
@CLAassistant
Copy link

CLAassistant commented Aug 16, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ jordanjones243
✅ jason-capsule42
❌ semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

sourcery-ai bot commented Aug 16, 2024

Reviewer's Guide by Sourcery

This pull request moves theming support from Beta to Main for the auro-popover component. The changes primarily involve updating the styling approach to use CSS custom properties for theming, replacing hardcoded values with design tokens, and restructuring the color token system. The implementation also includes some performance improvements and bug fixes.

File-Level Changes

Files Changes
src/style.scss
src/color.scss
src/tokens.scss
Replaced hardcoded color values with CSS custom properties for theming support
src/style.scss Updated size values to use design tokens instead of hardcoded pixel values
src/color.scss
src/tokens.scss
Added new color.scss and tokens.scss files for managing theme-related styles
src/auro-popover.js Updated the component's JavaScript to import and use the new style sheets
demo/api.md
docs/partials/api.md
Added theme support documentation in the API markdown file
CHANGELOG.md Updated CHANGELOG.md with new version information and feature descriptions
README.md Removed references to CSS custom property fallbacks in README.md
eslint.config.mjs Added new ESLint configuration file
scripts/generateDocs.mjs
scripts/staticStyles-template.js
Removed deprecated script files

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jordanjones243 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you provide more information about the removal of scripts/generateDocs.mjs and scripts/staticStyles-template.js? It would be helpful to know if their functionality has been replaced or is no longer needed.
  • The README.md file still references version 3.3.0-beta.3. Should this be updated to a non-beta version since this PR is moving theming support from Beta to Main?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 2 issues found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

demo/api.md Outdated Show resolved Hide resolved
docs/partials/api.md Show resolved Hide resolved
jordanjones243 and others added 4 commits September 30, 2024 13:09
BREAKING CHANGE: trigger major release for color theme support #63
# [4.0.0-beta.1](v3.3.0-beta.3...v4.0.0-beta.1) (2024-09-30)

### Bug Fixes

* resolve minor color theming issues ([89b344a](89b344a))

### Performance Improvements

* refactor custom component registration config ([d080c60](d080c60))
* update dependencies ([74ab81a](74ab81a))

### BREAKING CHANGES

* trigger major release for color theme support #63
@blackfalcon
Copy link
Member

🎉 This PR is included in version 4.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jason-capsule42 jason-capsule42 merged commit d8df30f into master Sep 30, 2024
8 of 9 checks passed
@blackfalcon
Copy link
Member

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update color tokens for theming support
5 participants