-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move theming support from Beta to Main #77
Conversation
# [3.3.0-beta.2](v3.3.0-beta.1...v3.3.0-beta.2) (2024-08-09) ### Bug Fixes * **popover:** update styles to reconfigure trigger and box-shadow ([b771780](b771780))
# [3.3.0-beta.3](v3.3.0-beta.2...v3.3.0-beta.3) (2024-08-15) ### Performance Improvements * update deps and add name as attribute when custom registered ([e5ceef4](e5ceef4))
|
Reviewer's Guide by SourceryThis pull request moves theming support from Beta to Main for the auro-popover component. The changes primarily involve updating the styling approach to use CSS custom properties for theming, replacing hardcoded values with design tokens, and restructuring the color token system. The implementation also includes some performance improvements and bug fixes. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jordanjones243 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you provide more information about the removal of
scripts/generateDocs.mjs
andscripts/staticStyles-template.js
? It would be helpful to know if their functionality has been replaced or is no longer needed. - The README.md file still references version
3.3.0-beta.3
. Should this be updated to a non-beta version since this PR is moving theming support from Beta to Main?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
BREAKING CHANGE: trigger major release for color theme support #63
# [4.0.0-beta.1](v3.3.0-beta.3...v4.0.0-beta.1) (2024-09-30) ### Bug Fixes * resolve minor color theming issues ([89b344a](89b344a)) ### Performance Improvements * refactor custom component registration config ([d080c60](d080c60)) * update dependencies ([74ab81a](74ab81a)) ### BREAKING CHANGES * trigger major release for color theme support #63
🎉 This PR is included in version 4.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
6e8ccea
to
9040491
Compare
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #63
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Move theming support for the popover component from beta to main, enabling customization through design tokens. Refactor the component to replace hardcoded size and color values with design tokens, and update documentation to guide users on restyling the component.
New Features:
Enhancements:
Documentation: