Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to support new auro-menu API #32

Closed
blackfalcon opened this issue Feb 3, 2022 · 0 comments · Fixed by #35
Closed

Update to support new auro-menu API #32

blackfalcon opened this issue Feb 3, 2022 · 0 comments · Fixed by #35
Assignees
@blackfalcon
Labels
Status: Work In Progress Issue or Pull Request work is in Progress Type: Feature New Feature
Milestone
auro-select v1.0-rc

Comments

@blackfalcon
Copy link
Member

blackfalcon commented Feb 3, 2022 •
edited
Loading

General Support Request

The auro-menu api has changed per this PR AlaskaAirlines/auro-menu#81

Support request

Update auro-dropdownmenu to support this new API

additional reference

AlaskaAirlines/auro-menu#83
@blackfalcon blackfalcon added auro-dropdownmenu not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature labels Feb 3, 2022
@blackfalcon blackfalcon added this to the auro-dropdownmenu v1.0-rc milestone Feb 3, 2022
@blackfalcon blackfalcon added Status: Work In Progress Issue or Pull Request work is in Progress and removed not-reviewed Issue has not been reviewed by Auro team members labels Feb 3, 2022
@blackfalcon blackfalcon self-assigned this Feb 4, 2022
@blackfalcon blackfalcon mentioned this issue Feb 7, 2022
Closed
@blackfalcon blackfalcon linked a pull request Feb 7, 2022 that will close this issue
Refactor and update per auro-menu API updates #35
Merged
6 tasks
@blackfalcon blackfalcon mentioned this issue Feb 7, 2022
Merged
6 tasks
blackfalcon added a commit that referenced this issue Feb 15, 2022
@blackfalcon
fix: update element to support new menu API #32 #33 #29
3917cc5 
Changes to be committed:
modified:   src/auro-dropdownmenu.js
modified:   src/style.scss
blackfalcon added a commit that referenced this issue Feb 15, 2022
@blackfalcon
fix: update element to support new menu API #32 #33 #29
0a01a5f 
Changes to be committed:
modified:   src/auro-dropdownmenu.js
modified:   src/style.scss
blackfalcon added a commit that referenced this issue Feb 15, 2022
@blackfalcon
fix: update element to support new menu API #32 #33 #29
40331e8 
Changes to be committed:
modified:   src/auro-dropdownmenu.js
modified:   src/style.scss
jason-capsule42 pushed a commit that referenced this issue Feb 22, 2022
@blackfalcon @jason-capsule42
fix: update element to support new menu API #32 #33 #29
22897aa 
Changes to be committed:
modified:   src/auro-dropdownmenu.js
modified:   src/style.scss
jason-capsule42 pushed a commit that referenced this issue Feb 22, 2022
@blackfalcon @jason-capsule42
fix: update element to support new menu API #32 #33 #29
cba7f68 
Changes to be committed:
modified:   src/auro-dropdownmenu.js
modified:   src/style.scss
jason-capsule42 pushed a commit that referenced this issue Feb 23, 2022
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
16e7c9a 
# 1.0.0 (2022-02-23)

### Bug Fixes

* **dependency:** use menu depency rather than peer to fix race condition ([3f3db40](3f3db40))
* **git:** fix workflow node version ([027fb02](027fb02))
* update element to support new menu API [#32](#32) [#33](#33) [#29](#29) ([cba7f68](cba7f68))

### Features

* **a11y:** trap tabindex while dropdown is expanded ([1abb75f](1abb75f))
* **API:** expose value ([0114255](0114255))
* **API:** initial code dump ([ba0281a](ba0281a))
* **menu:** auto-focus menu when dropdown opens ([d48c5ee](d48c5ee))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

Labels
Status: Work In Progress Issue or Pull Request work is in Progress Type: Feature New Feature
Projects
None yet
Milestone
auro-select v1.0-rc
Development

Successfully merging a pull request may close this issue.

Refactor and update per auro-menu API updates AlaskaAirlines/auro-select
2 participants
@blackfalcon @braven112