a11y review and functional refactor #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackfalcon
force-pushed
the
dsande/a11yReview
branch
4 times, most recently
from
7a6cb36 to
75661b2
Compare
This was
linked to
issues
Feb 2, 2022
blackfalcon
force-pushed
the
dsande/a11yReview
branch
8 times, most recently
from
a4d2efc to
2963df2
Compare
This commit removes the manual complexity with keyboard experiences and adds support for aria roles to increase voice over experiences. Changes to be committed: modified: src/auro-menu.js modified: src/auro-menuoption.js modified: src/style-menuoption.scss modified: test/auro-menu.test.js modified: web-test-runner.config.mjs
Changes to be committed: modified: README.md modified: demo/demo.md modified: docs/api.md
blackfalcon
force-pushed
the
dsande/a11yReview
branch
from
45d5d0a to
f8da94a
Compare
Changes to be committed: modified: docs/api.md modified: src/auro-menuoption.js
|
Sorry for adding this late, thought for sure I already put this in here. After linking this to dropdownmenu locally, updating the eventListener to the new name and accounting for the change away from using index to make a selection I noticed the following regressions:
|
|
@jason-capsule42 dropdown menu has a dependency on menu, not the other way around. The scope of this PR is to refactor the interaction functions of menu to meet an a11y spec that the previous version did not. After this merge, dropdown menu (which is not released) will need to be refactored. |
jason-capsule42
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #64, #55, #66
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
The scope of this PR will address the manual assignment of an index attribute to manage keyboard events and pre-selected options.
This PR also addresses the remaining a11y interactions and voice-over feedback.
Demo: https://alaskaairlines-auro-menu-pr-81.surge.sh/
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team