-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jbaker/beta release #206
Jbaker/beta release #206
Conversation
BREAKING CHANGE: trigger major release for color theme support #198
# [3.0.0-beta.1](v2.11.0-beta.1...v3.0.0-beta.1) (2024-10-03) ### Bug Fixes * add extension for SSR support ([2b5ee5a](2b5ee5a)) ### Performance Improvements * refactor custom component registration config ([7dbb9c3](7dbb9c3)) * update dependencies ([19dfb75](19dfb75)) ### BREAKING CHANGES * trigger major release for color theme support #198
Reviewer's Guide by SourceryThis pull request implements several changes to the auro-select component, including updating dependencies, refactoring code for better performance and maintainability, and adding new features such as theme support and placeholder text color customization. Updated class diagram for AuroSelect componentclassDiagram
class AuroSelect {
- runtimeUtils: AuroLibraryRuntimeUtils
- dropdownTag: String
+ configureDropdown()
+ updateDisplayedValue(option)
+ performUpdate()
}
class AuroLibraryRuntimeUtils
class AuroDependencyVersioning {
+ generateTag(componentName, version, component)
}
AuroSelect --> AuroLibraryRuntimeUtils
AuroSelect --> AuroDependencyVersioning
AuroSelect --> AuroDropdown
AuroDependencyVersioning --> AuroDropdown
AuroSelect : +styles = [styleCss, colorCss, tokensCss]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jason-capsule42 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟡 Documentation: 3 issues found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Refactor the auro-select component to use dynamic tag generation for auro-dropdown, introduce a new versioning system for dependency components, and enhance theming capabilities. Update documentation and tests to reflect these changes, and clean up deprecated scripts and configurations.
New Features:
Enhancements:
Documentation:
Tests:
Chores: