Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update color tokens for theming support #198

Closed
2 tasks
jordanjones243 opened this issue Aug 12, 2024 · 1 comment · Fixed by #199, #206 or #207
Closed
2 tasks

Update color tokens for theming support #198

jordanjones243 opened this issue Aug 12, 2024 · 1 comment · Fixed by #199, #206 or #207
Assignees
@jordanjones243
Labels
auro-select

Comments

@jordanjones243
Copy link
Contributor

General Support Request

In order to make Auro components themeable, we need to make sure there are no hard-coded and correct semanticly named tokens within the component. There also needs to be investigation around border rules which have a combination of size and color tokens, making them more complex, as well as background-color and color rules.

Possible Solution

Work with designers to figure out what tokens need updated values or renamed.

Additional context

This work stems from theming work happening to all Auro components:

Rules and tokens to be edited can be found in the comments.

Acceptance Criteria:

  • All tier 3 token names have been implemented.
  • Colors identified below have been updated to their tier 3 token name.
@jordanjones243 jordanjones243 added not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature auro-select labels Aug 12, 2024
@jordanjones243 jordanjones243 self-assigned this Aug 12, 2024
@jordanjones243 jordanjones243 removed the not-reviewed Issue has not been reviewed by Auro team members label Aug 12, 2024
jordanjones243 added a commit that referenced this issue Aug 13, 2024
@jordanjones243
feat: implement tier 3 color tokens #198
095c7b2
@jordanjones243 jordanjones243 mentioned this issue Aug 13, 2024
Merged
6 tasks
@jordanjones243 jordanjones243 linked a pull request Aug 13, 2024 that will close this issue
Implement color theming support #199
Merged
6 tasks
jordanjones243 added a commit that referenced this issue Aug 22, 2024
@jordanjones243
feat: implement tier 3 color tokens #198
4a3bebe
jordanjones243 added a commit that referenced this issue Aug 23, 2024
@jordanjones243
feat: implement tier 3 color tokens #198
c5940e7
blackfalcon pushed a commit that referenced this issue Aug 23, 2024
@semantic-release-bot
chore(release): 2.11.0-beta.1 [skip ci]
62b17c5 
# [2.11.0-beta.1](v2.10.6...v2.11.0-beta.1) (2024-08-23)

### Features

* implement tier 3 color tokens [#198](#198) ([c5940e7](c5940e7))

### Performance Improvements

* move help text functionality into dropdown slot ([8607c0f](8607c0f))
* update dependencies and scripts to latest versions ([f40f971](f40f971))
* use custom version of dropdown ([617c8f7](617c8f7))
@jordanjones243
Copy link
Contributor Author

Ticket is blocked until auro-menu's and auro-dropdown's theming support changes have been released.

@jason-capsule42 jason-capsule42 removed the Type: Feature New Feature label Oct 3, 2024
jordanjones243 added a commit that referenced this issue Oct 3, 2024
@jordanjones243
perf: update dependencies
188fe47 
BREAKING CHANGE: trigger major release for color theme support #198
jordanjones243 added a commit that referenced this issue Oct 3, 2024
@jordanjones243
perf: update dependencies
19dfb75 
BREAKING CHANGE: trigger major release for color theme support #198
blackfalcon pushed a commit that referenced this issue Oct 3, 2024
@semantic-release-bot
chore(release): 3.0.0-beta.1 [skip ci]
1fbedf7 
# [3.0.0-beta.1](v2.11.0-beta.1...v3.0.0-beta.1) (2024-10-03)

### Bug Fixes

* add extension for SSR support ([2b5ee5a](2b5ee5a))

### Performance Improvements

* refactor custom component registration config ([7dbb9c3](7dbb9c3))
* update dependencies ([19dfb75](19dfb75))

### BREAKING CHANGES

* trigger major release for color theme support #198
jason-capsule42 pushed a commit that referenced this issue Oct 4, 2024
@jordanjones243 @jason-capsule42
feat: implement tier 3 color tokens #198
2a2e43c
jason-capsule42 pushed a commit that referenced this issue Oct 4, 2024
@semantic-release-bot @jason-capsule42
chore(release): 2.11.0-beta.1 [skip ci]
9b439cd 
* implement tier 3 color tokens [#198](#198) ([c5940e7](c5940e7))

* move help text functionality into dropdown slot ([8607c0f](8607c0f))
* update dependencies and scripts to latest versions ([f40f971](f40f971))
* use custom version of dropdown ([617c8f7](617c8f7))
jason-capsule42 pushed a commit that referenced this issue Oct 4, 2024
@jordanjones243 @jason-capsule42
perf: update dependencies
787c64f 
BREAKING CHANGE: trigger major release for color theme support #198
jason-capsule42 pushed a commit that referenced this issue Oct 4, 2024
@semantic-release-bot @jason-capsule42
chore(release): 3.0.0-beta.1 [skip ci]
3a6476b 
# [3.0.0-beta.1](v2.11.0-beta.1...v3.0.0-beta.1) (2024-10-03)

### Bug Fixes

* add extension for SSR support ([2b5ee5a](2b5ee5a))

### Performance Improvements

* refactor custom component registration config ([7dbb9c3](7dbb9c3))
* update dependencies ([19dfb75](19dfb75))

### BREAKING CHANGES

* trigger major release for color theme support #198
@jason-capsule42 jason-capsule42 linked a pull request Oct 4, 2024 that will close this issue
Jbaker/beta release #206
Merged
6 tasks
blackfalcon pushed a commit that referenced this issue Oct 4, 2024
@semantic-release-bot
chore(release): 3.0.0-beta.1 [skip ci]
5d440ae 
# [3.0.0-beta.1](v2.10.8...v3.0.0-beta.1) (2024-10-04)

### Bug Fixes

* add extension for SSR support ([00c50d1](00c50d1))

### Features

* implement tier 3 color tokens [#198](#198) ([2a2e43c](2a2e43c))

### Performance Improvements

* move help text functionality into dropdown slot ([1e60c4a](1e60c4a))
* refactor custom component registration config ([472d8ac](472d8ac))
* update dependencies ([787c64f](787c64f))
* update dependencies and scripts to latest versions ([3441708](3441708))
* use custom version of dropdown ([0377663](0377663))

### BREAKING CHANGES

* trigger major release for color theme support #198
jason-capsule42 pushed a commit that referenced this issue Oct 4, 2024
@jordanjones243 @jason-capsule42
feat: implement tier 3 color tokens #198
19369cc
jason-capsule42 pushed a commit that referenced this issue Oct 4, 2024
@semantic-release-bot @jason-capsule42
chore(release): 2.11.0-beta.1 [skip ci]
8ef5e68 
* implement tier 3 color tokens [#198](#198) ([c5940e7](c5940e7))

* move help text functionality into dropdown slot ([8607c0f](8607c0f))
* update dependencies and scripts to latest versions ([f40f971](f40f971))
* use custom version of dropdown ([617c8f7](617c8f7))
jason-capsule42 pushed a commit that referenced this issue Oct 4, 2024
@jordanjones243 @jason-capsule42
perf: update dependencies
e563427 
BREAKING CHANGE: trigger major release for color theme support #198
jason-capsule42 pushed a commit that referenced this issue Oct 4, 2024
@semantic-release-bot @jason-capsule42
chore(release): 3.0.0-beta.1 [skip ci]
c54d73c 
# [3.0.0-beta.1](v2.11.0-beta.1...v3.0.0-beta.1) (2024-10-03)

### Bug Fixes

* add extension for SSR support ([2b5ee5a](2b5ee5a))

### Performance Improvements

* refactor custom component registration config ([7dbb9c3](7dbb9c3))
* update dependencies ([19dfb75](19dfb75))

### BREAKING CHANGES

* trigger major release for color theme support #198
blackfalcon pushed a commit that referenced this issue Oct 4, 2024
@semantic-release-bot
chore(release): 3.0.0 [skip ci]
58536c7 
# [3.0.0](v2.10.8...v3.0.0) (2024-10-04)

### Bug Fixes

* add extension for SSR support ([84da4ea](84da4ea))

### Features

* implement tier 3 color tokens [#198](#198) ([19369cc](19369cc))

### Performance Improvements

* move help text functionality into dropdown slot ([0d6aff5](0d6aff5))
* refactor custom component registration config ([9bada60](9bada60))
* update dependencies ([e563427](e563427))
* update dependencies and scripts to latest versions ([99420fd](99420fd))
* use custom version of dropdown ([3d3f20e](3d3f20e))

### BREAKING CHANGES

* trigger major release for color theme support #198
@jordanjones243 jordanjones243 linked a pull request Oct 4, 2024 that will close this issue
reinstate deleted release information #207
Merged
6 tasks
@jordanjones243 jordanjones243 mentioned this issue Oct 4, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanjones243 jordanjones243

Labels
auro-select
Projects
None yet
Milestone
No milestone
3 participants
@jason-capsule42 @jordanjones243 @Patrick-Daly-AA