Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bitmap in ROFRecords #13385

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

mconcas
Copy link
Collaborator

@mconcas mconcas commented Aug 14, 2024

@shahor02 : I am still testing to see if it actually works.
The logic would be to tag the ROFRecords for seeding vertices in any case with corresponding two bits (first iteration, upc iteration). Then tag the tracks ROFs if we found tracks there.
If you believe, I can tag only the track ones using vertices flags and any filtering can be done on a later analysis.

@mconcas mconcas requested a review from shahor02 as a code owner August 14, 2024 16:45
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@shahor02
Copy link
Collaborator

@mconcas if you want, you can set it first to the vertices rofrecord vector than copy it to track's rofrecords, but only the latter is loaded in the AODProducer.

@mconcas
Copy link
Collaborator Author

mconcas commented Aug 14, 2024

@mconcas if you want, you can set it first to the vertices rofrecord vector than copy it to track's rofrecords, but only the latter is loaded in the AODProducer.

Ah true, I would then just keep this logic just to save one extra iteration on the vertices.

@mconcas mconcas force-pushed the pr_upc_bitmap_in_rof branch from 981ace7 to c5f88c3 Compare August 14, 2024 22:11
@mconcas
Copy link
Collaborator Author

mconcas commented Aug 14, 2024

Screenshot from 2024-08-15 00-15-44
In red: bits related to the tracks ROFRecord
In blue: bits related to vert ROFRecord

  • if bit==0: no vertices -> no tracks
  • if bit==1 -> value==2 -> vertices from first iterations, tracks from the first iteration
  • if bit==2 -> value==4 -> vertices from UPC iteration, tracks from UPC iteration

as there can be vertices with no tracks (mostly UPC ones!), red is different than blue and there are more empty ROFs

@mconcas mconcas added the async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 label Aug 14, 2024
@alibuild
Copy link
Collaborator

alibuild commented Aug 14, 2024

Error while checking build/O2/fullCI for c5f88c3 at 2024-08-15 07:27:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13385-slc8_x86-64/0/Detectors/ITSMFT/ITS/reconstruction/src/ClustererTask.cxx:36:16: error: use '= default' to define a trivial destructor [modernize-use-equals-default]
/sw/SOURCES/O2/13385-slc8_x86-64/0/Detectors/ITSMFT/MFT/simulation/src/DigitizerTask.cxx:36:16: error: use '= default' to define a trivial destructor [modernize-use-equals-default]
/sw/SOURCES/O2/13385-slc8_x86-64/0/Detectors/GlobalTracking/src/MatchGlobalFwd.cxx:844:17: error: use '= default' to define a trivial default constructor [modernize-use-equals-default]
/sw/SOURCES/O2/13385-slc8_x86-64/0/Detectors/ITSMFT/ITS/workflow/src/ThresholdAggregatorSpec.cxx:27:25: error: use '= default' to define a trivial default constructor [modernize-use-equals-default]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@mconcas mconcas merged commit b8782ae into AliceO2Group:dev Aug 15, 2024
12 checks passed
chiarazampolli pushed a commit that referenced this pull request Aug 26, 2024
@chiarazampolli chiarazampolli removed the async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 label Aug 26, 2024
@chiarazampolli
Copy link
Collaborator

Label removed, PR is in async-v1-01-16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants