Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bitmap in ROFRecords #13385

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Add support for bitmap in ROFRecords #13385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions DataFormats/Detectors/ITSMFT/common/include/DataFormatsITSMFT/ROFRecord.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,14 @@ class ROFRecord
void setFirstEntry(int idx) { mROFEntry.setFirstEntry(idx); }
void setNEntries(int n) { mROFEntry.setEntries(n); }

uint32_t getFlags() const { return mBits; }
void setFlags(uint32_t flags) { mBits = flags; }
void setFlag(uint8_t flagIndex) { mBits |= (1 << flagIndex); }
void resetFlag(uint8_t flagIndex) { mBits &= ~(1 << flagIndex); }
bool getFlag(uint8_t flagIndex) const { return mBits & (1 << flagIndex); }
void clearAllFlags() { mBits = 0; }
void setAllFlags() { mBits = ~0; }

const BCData& getBCData() const { return mBCData; }
BCData& getBCData() { return mBCData; }
EvIdx getEntry() const { return mROFEntry; }
Expand Down Expand Up @@ -91,8 +99,8 @@ class ROFRecord
o2::InteractionRecord mBCData; // BC data for given trigger
EvIdx mROFEntry; //< reference on the 1st object of the ROF in data
ROFtype mROFrame = 0; //< frame ID

ClassDefNV(ROFRecord, 2);
uint32_t mBits = 0;
ClassDefNV(ROFRecord, 3);
};

/// this is a simple reference connecting (composed) MC event ID (from the EventRecord of the RunContext)
Expand Down
2 changes: 1 addition & 1 deletion Detectors/ITSMFT/ITS/tracking/src/TrackerTraits.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ void TrackerTraits::computeLayerTracklets(const int iteration, int iROFslice, in

for (int iV{startVtx}; iV < endVtx; ++iV) {
auto& primaryVertex{primaryVertices[iV]};
if (primaryVertex.isFlagSet(1) && iteration != 3) {
if (primaryVertex.isFlagSet(2) && iteration != 3) {
continue;
}
const float resolution = o2::gpu::CAMath::Sqrt(Sq(mTrkParams[iteration].PVres) / primaryVertex.getNContributors() + Sq(tf->getPositionResolution(iLayer)));
Expand Down
47 changes: 26 additions & 21 deletions Detectors/ITSMFT/ITS/tracking/src/TrackingInterface.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,15 +118,14 @@ void ITSTrackingInterface::run(framework::ProcessingContext& pc)
}

auto rofsinput = pc.inputs().get<gsl::span<o2::itsmft::ROFRecord>>("ROframes");
auto& rofs = pc.outputs().make<std::vector<o2::itsmft::ROFRecord>>(Output{"ITS", "ITSTrackROF", 0}, rofsinput.begin(), rofsinput.end());
auto& trackROFvec = pc.outputs().make<std::vector<o2::itsmft::ROFRecord>>(Output{"ITS", "ITSTrackROF", 0}, rofsinput.begin(), rofsinput.end());
auto& irFrames = pc.outputs().make<std::vector<o2::dataformats::IRFrame>>(Output{"ITS", "IRFRAMES", 0});
const auto& alpParams = o2::itsmft::DPLAlpideParam<o2::detectors::DetID::ITS>::Instance(); // RS: this should come from CCDB

irFrames.reserve(rofs.size());
irFrames.reserve(trackROFvec.size());
int nBCPerTF = alpParams.roFrameLengthInBC;

LOGP(info, "ITSTracker pulled {} clusters, {} RO frames", compClusters.size(), rofs.size());

LOGP(info, "ITSTracker pulled {} clusters, {} RO frames", compClusters.size(), trackROFvec.size());
const dataformats::MCTruthContainer<MCCompLabel>* labels = nullptr;
gsl::span<itsmft::MC2ROFRecord const> mc2rofs;
if (mIsMC) {
Expand Down Expand Up @@ -165,8 +164,8 @@ void ITSTrackingInterface::run(framework::ProcessingContext& pc)

gsl::span<const unsigned char>::iterator pattIt = patterns.begin();

gsl::span<itsmft::ROFRecord> rofspan(rofs);
mTimeFrame->loadROFrameData(rofspan, compClusters, pattIt, mDict, labels);
gsl::span<itsmft::ROFRecord> trackROFspan(trackROFvec);
mTimeFrame->loadROFrameData(trackROFspan, compClusters, pattIt, mDict, labels);
pattIt = patterns.begin();
std::vector<int> savedROF;
auto logger = [&](std::string s) { LOG(info) << s; };
Expand All @@ -175,12 +174,12 @@ void ITSTrackingInterface::run(framework::ProcessingContext& pc)

FastMultEst multEst; // mult estimator
std::vector<bool> processingMask, processUPCMask;
int cutVertexMult{0}, cutUPCVertex{0}, cutRandomMult = int(rofs.size()) - multEst.selectROFs(rofs, compClusters, physTriggers, processingMask);
int cutVertexMult{0}, cutUPCVertex{0}, cutRandomMult = int(trackROFvec.size()) - multEst.selectROFs(trackROFvec, compClusters, physTriggers, processingMask);
processUPCMask.resize(processingMask.size(), false);
mTimeFrame->setMultiplicityCutMask(processingMask);
float vertexerElapsedTime{0.f};
if (mRunVertexer) {
vertROFvec.reserve(rofs.size());
vertROFvec.reserve(trackROFvec.size());
// Run seeding vertexer
if constexpr (isGPU) {
vertexerElapsedTime = mVertexer->clustersToVerticesHybrid(logger);
Expand All @@ -192,9 +191,9 @@ void ITSTrackingInterface::run(framework::ProcessingContext& pc)
}
const auto& multEstConf = FastMultEstConfig::Instance(); // parameters for mult estimation and cuts
gsl::span<const std::pair<MCCompLabel, float>> vMCRecInfo;
for (auto iRof{0}; iRof < rofspan.size(); ++iRof) {
for (auto iRof{0}; iRof < trackROFspan.size(); ++iRof) {
std::vector<Vertex> vtxVecLoc;
auto& vtxROF = vertROFvec.emplace_back(rofspan[iRof]);
auto& vtxROF = vertROFvec.emplace_back(trackROFspan[iRof]);
vtxROF.setFirstEntry(vertices.size());
if (mRunVertexer) {
auto vtxSpan = mTimeFrame->getPrimaryVertices(iRof);
Expand All @@ -219,6 +218,11 @@ void ITSTrackingInterface::run(framework::ProcessingContext& pc)
allVerticesLabels.push_back(vMCRecInfo[iV].first);
allVerticesPurities.push_back(vMCRecInfo[iV].second);
}
if (v.isFlagSet(2)) { // Vertex is reconstructed in a second iteration
vtxROF.setFlag(2); // flag that at least one vertex is from the second iteration
} else {
vtxROF.setFlag(1); // flag that at least one vertex is from the first iteration
}
}
if (processingMask[iRof] && !selROF) { // passed selection in clusters and not in vertex multiplicity
LOGP(info, "ROF {} rejected by the vertex multiplicity selection [{},{}]", iRof, multEstConf.cutMultVtxLow, multEstConf.cutMultVtxHigh);
Expand All @@ -236,22 +240,22 @@ void ITSTrackingInterface::run(framework::ProcessingContext& pc)
}
}
if (mRunVertexer) {
LOG(info) << fmt::format(" - rejected {}/{} ROFs: random/mult.sel:{} (seed {}), vtx.sel:{}, upc.sel:{}", cutRandomMult + cutVertexMult + cutUPCVertex, rofspan.size(), cutRandomMult, multEst.lastRandomSeed, cutVertexMult, cutUPCVertex);
LOG(info) << fmt::format(" - rejected {}/{} ROFs: random/mult.sel:{} (seed {}), vtx.sel:{}, upc.sel:{}", cutRandomMult + cutVertexMult + cutUPCVertex, trackROFspan.size(), cutRandomMult, multEst.lastRandomSeed, cutVertexMult, cutUPCVertex);
LOG(info) << fmt::format(" - Vertex seeding total elapsed time: {} ms for {} ({} + {}) vertices found in {}/{} ROFs",
vertexerElapsedTime,
mTimeFrame->getPrimaryVerticesNum(),
mTimeFrame->getTotVertIteration()[0],
o2::its::VertexerParamConfig::Instance().nIterations > 1 ? mTimeFrame->getTotVertIteration()[1] : 0,
rofspan.size() - mTimeFrame->getNoVertexROF(),
rofspan.size());
trackROFspan.size() - mTimeFrame->getNoVertexROF(),
trackROFspan.size());
}

if (mOverrideBeamEstimation) {
LOG(info) << fmt::format(" - Beam position set to: {}, {} from meanvertex object", mTimeFrame->getBeamX(), mTimeFrame->getBeamY());
} else {
LOG(info) << fmt::format(" - Beam position computed for the TF: {}, {}", mTimeFrame->getBeamX(), mTimeFrame->getBeamY());
}
if (mCosmicsProcessing && compClusters.size() > 1500 * rofspan.size()) {
if (mCosmicsProcessing && compClusters.size() > 1500 * trackROFspan.size()) {
LOG(error) << "Cosmics processing was requested with an average detector occupancy exceeding 1.e-7, skipping TF processing.";
} else {

Expand Down Expand Up @@ -279,17 +283,18 @@ void ITSTrackingInterface::run(framework::ProcessingContext& pc)
LOG(warning) << fmt::format(" - The processed timeframe had {} clusters with wild z coordinates, check the dictionaries", mTimeFrame->hasBogusClusters());
}

for (unsigned int iROF{0}; iROF < rofs.size(); ++iROF) {
auto& rof{rofs[iROF]};
for (unsigned int iROF{0}; iROF < trackROFvec.size(); ++iROF) {
auto& tracksROF{trackROFvec[iROF]};
auto& vtxROF = vertROFvec[iROF];
auto& tracks = mTimeFrame->getTracks(iROF);
auto number{tracks.size()};
auto first{allTracks.size()};
int offset = -rof.getFirstEntry(); // cluster entry!!!
rof.setFirstEntry(first);
rof.setNEntries(number);

int offset = -tracksROF.getFirstEntry(); // cluster entry!!!
tracksROF.setFirstEntry(first);
tracksROF.setNEntries(number);
tracksROF.setFlags(number ? vtxROF.getFlags() : 0); // copies 0xffffffff if cosmics
if (processingMask[iROF]) {
irFrames.emplace_back(rof.getBCData(), rof.getBCData() + nBCPerTF - 1).info = tracks.size();
irFrames.emplace_back(tracksROF.getBCData(), tracksROF.getBCData() + nBCPerTF - 1).info = tracks.size();
}
allTrackLabels.reserve(mTimeFrame->getTracksLabel(iROF).size()); // should be 0 if not MC
std::copy(mTimeFrame->getTracksLabel(iROF).begin(), mTimeFrame->getTracksLabel(iROF).end(), std::back_inserter(allTrackLabels));
Expand Down
2 changes: 1 addition & 1 deletion Detectors/ITSMFT/ITS/tracking/src/VertexerTraits.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ void VertexerTraits::computeVertices(const int iteration)
mTimeFrame->getTrackletClusters(rofId)[iCluster].getAvgDistance2()); // In place of chi2

vertices.back().setTimeStamp(rofId);
vertices.back().setFlags(iteration);
vertices.back().setFlags(iteration + 1); // This can be interpreted as the UPC flag if it is > 0
if (mTimeFrame->hasMCinformation()) {
std::vector<o2::MCCompLabel> labels;
for (auto& index : mTimeFrame->getTrackletClusters(rofId)[iCluster].getLabels()) {
Expand Down
Loading