Backend abstraction layer #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows to use different backend either from cimgui-go or manually ijmplemented. The idea is to use same giu code (especially MasterWindowFlags) in abstraction from used backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this is to add one more abstraction layer for backend in giu.
Initial problem was that generally we want to use same giu code in abstraction from what backend is being used.
This PR adds an abstract
GIUBackendtype (alias tobackend.Backend[MasterWindowFlags])This PR also adds GLFWBackend type which implements GIUBackend and is the default backend so that everything works as it used to, however now another addition to giu could be made to add more backends and user could chose btween them easily.
Also one side-change: MasterWindow does not store cimgui's Backend pointer anymore. Now the only place where Backend is stored is Context and MasterWindow stores its context's pointer.