-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: fetch only single needed option list in option list editor #14266
Conversation
6ab574d
to
184a65a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14266 +/- ##
=======================================
Coverage 95.56% 95.56%
=======================================
Files 1837 1842 +5
Lines 23856 23882 +26
Branches 2754 2752 -2
=======================================
+ Hits 22798 22824 +26
Misses 801 801
Partials 257 257 ☔ View full report in Codecov by Sentry. |
81174f3
to
3965e05
Compare
e618690
to
d91e342
Compare
d91e342
to
da0106c
Compare
da0106c
to
165f9ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 😄 I really like the changes to OptionListEditor.tsx
I've suggest some renames, and to remove an empty css file. Otherwise it looks really good 🚀
...config/editModal/EditOptions/OptionTabs/EditTab/OptionListEditor/OptionListEditor.module.css
Outdated
Show resolved
Hide resolved
...ditOptions/OptionTabs/EditTab/OptionListEditor/LibraryOptionsEditor/LibraryOptionsEditor.tsx
Outdated
Show resolved
Hide resolved
.../EditOptions/OptionTabs/EditTab/OptionListEditor/ManualOptionsEditor/ManualOptionsEditor.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
frontend/packages/shared/src/hooks/mutations/useAddOptionListMutation.ts
Show resolved
Hide resolved
.../EditOptions/OptionTabs/EditTab/OptionListEditor/ManualOptionsEditor/ManualOptionsEditor.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK 🙌
Description
Related Issue(s)
Verification