Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fetch only single needed option list in option list editor #14266

Merged
merged 7 commits into from
Dec 20, 2024

Conversation

standeren
Copy link
Contributor

Description

  • add query in frontend to utilize the fetch single option list endpoint
  • fetching the option list needed in ux-editor using the new endpoint
    • this also included a little refactoring in both code and tests
  • add a new query cache key to store the individual option lists

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Dec 12, 2024
@standeren standeren force-pushed the add-use-option-list-query branch from 6ab574d to 184a65a Compare December 12, 2024 08:09
@standeren standeren added skip-releasenotes Issues that do not make sense to list in our release notes team/studio-domain1 labels Dec 12, 2024
@standeren standeren linked an issue Dec 12, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 98.43750% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.56%. Comparing base (6714508) to head (a2e639f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...Editor/ManualOptionsEditor/ManualOptionsEditor.tsx 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14266   +/-   ##
=======================================
  Coverage   95.56%   95.56%           
=======================================
  Files        1837     1842    +5     
  Lines       23856    23882   +26     
  Branches     2754     2752    -2     
=======================================
+ Hits        22798    22824   +26     
  Misses        801      801           
  Partials      257      257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren force-pushed the add-use-option-list-query branch from 81174f3 to 3965e05 Compare December 12, 2024 08:55
@standeren standeren force-pushed the add-use-option-list-query branch 4 times, most recently from e618690 to d91e342 Compare December 12, 2024 11:20
@Konrad-Simso Konrad-Simso self-assigned this Dec 12, 2024
@standeren standeren force-pushed the add-use-option-list-query branch from d91e342 to da0106c Compare December 12, 2024 11:50
@standeren standeren force-pushed the add-use-option-list-query branch from da0106c to 165f9ff Compare December 12, 2024 11:53
Copy link
Contributor

@Konrad-Simso Konrad-Simso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 😄 I really like the changes to OptionListEditor.tsx

I've suggest some renames, and to remove an empty css file. Otherwise it looks really good 🚀

@standeren standeren assigned Konrad-Simso and unassigned standeren Dec 13, 2024
Copy link
Contributor

@Konrad-Simso Konrad-Simso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Konrad-Simso Konrad-Simso removed their assignment Dec 13, 2024
Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK 🙌

@ErlingHauan ErlingHauan merged commit a578aab into main Dec 20, 2024
10 checks passed
@ErlingHauan ErlingHauan deleted the add-use-option-list-query branch December 20, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Fetch optionLists in individual requests
4 participants