Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update codelist config design #14276

Merged
merged 52 commits into from
Jan 9, 2025

Conversation

Konrad-Simso
Copy link
Contributor

Description

Update the design of the codelist section of our config page. Earlier discuessed in another PR

Before

image

After

image

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Dec 12, 2024
@Konrad-Simso Konrad-Simso added skip-releasenotes Issues that do not make sense to list in our release notes team/studio-domain1 skip-documentation Issues where updating documentation is not relevant solution/studio/designer Issues related to the Altinn Studio Designer solution. and removed solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Dec 12, 2024
@Konrad-Simso Konrad-Simso linked an issue Dec 12, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 98.63946% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.58%. Comparing base (465fc97) to head (59cce4a).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...itModal/EditOptions/OptionTabs/EditTab/EditTab.tsx 92.59% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14276   +/-   ##
=======================================
  Coverage   95.57%   95.58%           
=======================================
  Files        1864     1867    +3     
  Lines       24151    24210   +59     
  Branches     2786     2787    +1     
=======================================
+ Hits        23082    23140   +58     
- Misses        812      814    +2     
+ Partials      257      256    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@standeren standeren self-assigned this Dec 13, 2024
…during onBlurAny and onClose no longer contains any logic.
@Konrad-Simso
Copy link
Contributor Author

Konrad-Simso commented Dec 13, 2024

Sorry for the late commit, i saw it when doing review of your code @standeren in this PR and thought it could be changed here as your PR is not related to the component itself

Copy link
Contributor

@standeren standeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, but I have some suggestions 🤗

@standeren standeren assigned Konrad-Simso and unassigned standeren Dec 13, 2024
@standeren
Copy link
Contributor

standeren commented Dec 13, 2024

And I also have a general comment concerning the delete-functionality, as well as the conflicted-sources (trying to set a library id if manual options are set and vice versa).

We should sync the design here along with the image-component. For the image component the delete-choices are separated between deleting the ref and deleting the actual source.

Skjermbilde 2024-12-13 kl  09 10 57

When there are conflicting sources it is visualized like this in the image component:

Skjermopptak.2024-12-13.kl.09.11.34.mov

Also, when I have connected an optionlist in the Velg kodeliste I get the same codelist id visualized in the Ani referanse-id:

Skjermopptak.2024-12-13.kl.12.53.07.mov

And one last small thing I noticed, when I have a faulty codeList I cant remove it. Might be that this can be fixed easier when the other PR that fetches only the specified code list is implemented tho.

Skjermbilde 2024-12-13 kl  12 49 40

@standeren standeren removed their assignment Jan 6, 2025
@standeren standeren assigned Konrad-Simso and unassigned standeren Jan 7, 2025
@standeren standeren removed their assignment Jan 7, 2025
Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing:

  • Immediately closing the modal when on a component options list should return us back to the original view
  • Text in modal that lists code lists from library was larger than the modal`s heading
  • Code list name text was larger than the image component name text
  • Small adjustments to spacing

We fixed this in pair programming 😊

Final result:
bilde

bilde

@Konrad-Simso Konrad-Simso merged commit ffec39a into main Jan 9, 2025
10 checks passed
@Konrad-Simso Konrad-Simso deleted the feat/update-codelist-config-design branch January 9, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend skip-documentation Issues where updating documentation is not relevant skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Merge "select codelist" and "edit codelist" views
4 participants