Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enbesan harbour production buildings wrong icon/harbor area #390

Closed
Acidello opened this issue Dec 7, 2021 · 3 comments · Fixed by #432
Closed

Enbesan harbour production buildings wrong icon/harbor area #390

Acidello opened this issue Dec 7, 2021 · 3 comments · Fixed by #432
Assignees
@StingMcRay
Labels
anno 1800 changes or issues affecting features relating to Anno 1800 bug Something isn't working PresetParser Features or issues relationg to the PresetParser.
Milestone
Presets v5.0

Comments

@Acidello
Copy link

Acidello commented Dec 7, 2021

I also noticed that the icon for Salt Works is wrong, as there is a sugar icon named "A7_salt" while the correct one would be ""A7_salt_africa". Also, Salt Works misses its "free Harbor Harea" in front (which shall be 6x6). Lobster fishery's harbor area is 1 tile too long (should be 5x5 instead of 5x6).
@FroggieFrog
Copy link
Collaborator

The icon for Salt Works should be fixed in presets v4.0: #356

@StingMcRay
Copy link
Contributor

StingMcRay commented Dec 7, 2021 •
edited
Loading

It seams Icon is not the right one again.... i will look into it

EDIT
Also Harborblocker is off from it.... seams something did go wrong on the Salt Works....

@StingMcRay StingMcRay added anno 1800 changes or issues affecting features relating to Anno 1800 bug Something isn't working PresetParser Features or issues relationg to the PresetParser. labels Dec 7, 2021
@StingMcRay StingMcRay self-assigned this Dec 7, 2021
@StingMcRay StingMcRay added this to the Presets v5.0 milestone Jun 3, 2022
@StingMcRay
Copy link
Contributor

StingMcRay commented Jun 9, 2022 •
edited
Loading

Problem is fixed, i made an mistake in the changing of IconFilename process.

@StingMcRay StingMcRay mentioned this issue Jun 14, 2022
Closed
19 tasks
@StingMcRay StingMcRay mentioned this issue Jul 4, 2022
Merged
@FroggieFrog FroggieFrog linked a pull request Jul 18, 2022 that will close this issue
Update Presets to v5.0 #432
Merged
FroggieFrog added a commit that referenced this issue Jul 18, 2022
@StingMcRay @FroggieFrog
Update Presets to v5.0 (#432)
ccc750f 
* Update Presets to v5.0
* Add GU13 to GU14.3 Buildings (Anno 1800).
* Renewed all and Added icons for Anno 1800.
* Removed, Renewed and Added Icons for Anno 2205
* Added missing icons for Anno 1404 and Anno 2070
* Fixed Issue #389 (Missing Warehouses)
* Fixed issue #390 (wrongly icon salt works africa (Anno 1800).
* Fixed issue #390 (Blocked Area for Lobster Fishery)
* Fixed "Palace Wing - Gate" wrong measurements (Anno 1800).
* Added Missing Buildings for Anno 1404 and 2070
* Fixed Missing Translations (DLC's) for Anno 1404 and 2070
* Fixed translation Residence Building Names (Anno 2205)
* Updated / Redone color.json to version 1.0.3.0
* Updated treeLocalization.json (1.0.0.7)

Program Only:
* Removed Excluded Templates to be showed in the Preset Tree (AD need to be update before users notice this)
* Made GUID into Presets file only (not used by Users, Canvas or Preset Tree).
* Made GUID replace CSV File for DuxVitae's Tool.
* Added extra Icons for Duxvitae Tool.
* Solved Performance issues (Translation on Anno 2205 and Anno 1800).
* Made a text file for Missing IconFIleNames, to easier check the missing or not given ones.
* made some coloring output lines, to distinguish the difference between normal text, errors  and no error (only for Anno 1800 outputs).
* Fixed assets Translations Override Tag (GUID) for missing Translations (Anno 1800).

Known Issues:
Some icons of Anno 2205 are missing (#408)
Scenario 2 Buildings can be missing, still working on a solution. Its a twisted linked Assets file
All Fields for Region's Mining Slot Buildings are missing (Anno 2205, No Buildblocker information in files, would not be fixed)

* Small Color.json update
Request for whitesmoke colored Plaza Pavings
* fix some failing tests
* optimized images with zopflipng
* adjusted tests
* adjust documentaion comment
* moved extension methods
* added some tests

Co-authored-by: FroggieFrog <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StingMcRay StingMcRay

Labels
anno 1800 changes or issues affecting features relating to Anno 1800 bug Something isn't working PresetParser Features or issues relationg to the PresetParser.
Projects
None yet
Milestone
Presets v5.0
Development

Successfully merging a pull request may close this issue.

Update Presets to v5.0
3 participants
@FroggieFrog @StingMcRay @Acidello