Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong structure sizes #60

Closed
Braste opened this issue May 7, 2019 · 12 comments · Fixed by #325
Closed

Fix wrong structure sizes #60

Braste opened this issue May 7, 2019 · 12 comments · Fixed by #325
Labels
enhancement New feature or request Presets Issues on Preset Menu (or file)

Comments

@Braste
Copy link

Braste commented May 7, 2019

Please check the structure sizes, some of them are wrong. For example here are the correct sizes, that i found till now:

Big Betty: 7x4
Depot: 10x4
Small Trading Post: 7x11
Pier: 7x8
Sailing Shipyard: 7x15

@FroggieFrog
Copy link
Collaborator

I just checked without playing the game.
presets.json 3.1.1
Wiki

Big Betty
presets: 4x4
wiki: 4x6

Depot
presets: 14x4
wiki: 4x10

Small Trading Post
presets: 4x7
wiki: ---

Pier
presets: 4x6
wiki: 6x7

Sailing Shipyard
presets: 4x6
wiki: 6x15

@StingMcRay
Copy link
Contributor

I know but coastal buildings only measured the "Placeable " Building ground not the sea area that is 'Blocked'. On the Wiki is stated that also
The sizes in Preset are directly from the data files of anno

@FroggieFrog
Copy link
Collaborator

Then it makes sense to use existing values in presets.json.
Another approach would be to extend the datamodel and add separate blockers for land and sea. I don't know if those values exist in the extracted data.

I think the missing feature is to plan a harbour. But this could be complicated.

@StingMcRay
Copy link
Contributor

I do not know of there is a part of "Blocked' area data, i can look, but i can not do that today, i run some tests of an other branch and then i gone do something else today.
So, i case of this, i will look tomorrow on the buildblocker data files to see of i can find some of this data

@Braste
Copy link
Author

Braste commented May 8, 2019

I got my values from playing the game and counting the needed cells. And i didn't include the sea areas

@StingMcRay
Copy link
Contributor

So what you mean is that the 'measurements' of the data files > preset.json are wrong anyway ?

@Braste
Copy link
Author

Braste commented May 8, 2019

It seems so

@StingMcRay
Copy link
Contributor

StingMcRay commented May 8, 2019

When i have time tomorrow i will dive into this including to see of we can make something for the sea area
Thanks for reporting

@StingMcRay
Copy link
Contributor

As additional information :
The size that is in the preset is the size the building NEED on the coastline as example : the green box of the shipyard (sail) is counted as size)
afbeelding
Ofc : the measurements of the total size of the shipyard (and his sea blocking area) is also imported to know on pre-build harbors in the Anno Designer : So you know why this is.

I still will look into this matter tomorrow if i have some time :)

@StingMcRay StingMcRay added enhancement New feature or request Presets Issues on Preset Menu (or file) labels May 13, 2019
@StingMcRay
Copy link
Contributor

Extra Information :
I have found some values i can do something with, however i need to check all coastal buildings to see of all values are right
I can tel you already the 'x15' is a measurement to mark the building as 'endless water blocker' means nothing can be build before this building on the water line

@AgmasGold
Copy link
Collaborator

Can this issue be closed?

@StingMcRay
Copy link
Contributor

Yeah, i think it can be closed, as i can not find any data to do this or make this idea working

FroggieFrog added a commit that referenced this issue May 29, 2021
* Changed Anno 1800 BuildBlocker Process that will fix #60 and Part 1 #323
Update Presets to version 3.10:
* Added Tourists DLC Icons
* Added Tourists DLC Ornaments to the Presets Tree
* Added Tourists DLC Buildings to Presets Tree
* Added Tourists DLC Buildings to Color.json (v1.0.0.9)
Anno Designer (for next Version)
* Added translation for Tourist DLC Presets Tree Menu's

* Fix : Palace on the right tree menu
Fix : Missing Residence Icons : Arctic and New World

* Adjused the Test of BuildingBockProvider
Incase of this tests, i commented out the "wait for a key" in the program iit self

* - adjusted german localization

* - optimized images (1,80 MB -> 1,56 MB)

Co-authored-by: Sting Mcray <[email protected]>
Co-authored-by: FroggieFrog <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Presets Issues on Preset Menu (or file)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants