Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Planning Adjustments on Coastal Buildings and Blocked Area's #323

Closed
StingMcRay opened this issue Mar 31, 2021 · 2 comments · Fixed by #356
Closed

Planning Adjustments on Coastal Buildings and Blocked Area's #323

StingMcRay opened this issue Mar 31, 2021 · 2 comments · Fixed by #356
Labels
anno 1800 changes or issues affecting features relating to Anno 1800 enhancement New feature or request PresetParser Features or issues relationg to the PresetParser.
Milestone
Anno Designer 9.2...

Comments

@StingMcRay
Copy link
Contributor

StingMcRay commented Mar 31, 2021 •
edited
Loading

After Docklands and some extra information i have got, i will note the following

I gone try to fix all Coastal Buildings Measurements and i will add the same building with the so called Blocked Area's
I have seen the Parser use only the first numbers it see and this is wrong.
This will mean that, if i succeed the old coastal buildings used in a Layout stay as is, but when selecting the same building in the new preset (i hope i can do this as soon as possible) update.
For the Blocked area copies of it, i need maybe more time

But please give me some time to fix this

For the ones who pointed me on this flaw i say : Sorry but i did not see it then, but after Docklands and the extra info i got, i was digging deeper into the Buildblocker Files and then i noticed the whole Buildblocker was build into 4 different measurements. so, that you only see the "ground" measurement of coastal buildings has to do that the parser took only the first it saw.
My deepest apologizes.

Regards
Sting McRay
@StingMcRay StingMcRay added enhancement New feature or request anno 1800 changes or issues affecting features relating to Anno 1800 PresetParser Features or issues relationg to the PresetParser. labels Mar 31, 2021
@StingMcRay
Copy link
Contributor Author

Update :
Since today i fixed the wrong sizes of coastal Buildings, Here some examples
afbeelding
Upper is old presets, lower on is on the new presets (still busy to update all things)

@StingMcRay StingMcRay mentioned this issue May 27, 2021
Merged
@StingMcRay
Copy link
Contributor Author

This post need to be kept open, as i still want to try the Blocked Area part of this post

FroggieFrog added a commit that referenced this issue May 29, 2021
@StingMcRay @FroggieFrog
Update Presets v3.10 and Changed Buildblocker for All Buildings (#325)
01850aa 
* Changed Anno 1800 BuildBlocker Process that will fix #60 and Part 1 #323
Update Presets to version 3.10:
* Added Tourists DLC Icons
* Added Tourists DLC Ornaments to the Presets Tree
* Added Tourists DLC Buildings to Presets Tree
* Added Tourists DLC Buildings to Color.json (v1.0.0.9)
Anno Designer (for next Version)
* Added translation for Tourist DLC Presets Tree Menu's

* Fix : Palace on the right tree menu
Fix : Missing Residence Icons : Arctic and New World

* Adjused the Test of BuildingBockProvider
Incase of this tests, i commented out the "wait for a key" in the program iit self

* - adjusted german localization

* - optimized images (1,80 MB -> 1,56 MB)

Co-authored-by: Sting Mcray <[email protected]>
Co-authored-by: FroggieFrog <[email protected]>
Atria1234 added a commit to Atria1234/anno-designer that referenced this issue Sep 9, 2021
@Atria1234
Blocked harbor area can now be shown on canvas (AnnoDesigner#323)
5be9040
@StingMcRay StingMcRay mentioned this issue Sep 11, 2021
Merged
FroggieFrog pushed a commit that referenced this issue Sep 14, 2021
@Atria1234
Blocked harbor area can now be shown on canvas (#354)
896548a 
* Blocked harbor area can now be shown on canvas (#323)
* AnnoObject's BlockedArea and Direction is now loaded from presets when placing down a new building
* Unit tests for rotate direction
* Added BlockedAreaWidth property, modified brush used for rendering blocked areas to be more transparent
* Added caching for BlockedAreaScreenRect
* minor memory improvement
@FroggieFrog FroggieFrog linked a pull request Sep 14, 2021 that will close this issue
Update Preset Parser and Presets.json #356
Merged
FroggieFrog added a commit that referenced this issue Sep 14, 2021
@StingMcRay @FroggieFrog
Update Preset Parser and Presets.json (#356)
ba8a47f 
* Update Preset Parser and Presets.json for :
* Using Harbor BlockedArea Buildings (#323)
 - Using Spanish Language
 - Using decimals for Influence Radius (GU12 #346)
* Fixed Missing Influence Radius (#351) for
 - Iron Tower
 - Harbor Master Office
 - Repair Cranes
* Fixed Enbesa Salt Works icon
* Update treeLocalization.json (1.0.0.5)
* Update Presets.json (version 4.0)
* add info for easier debugging
* Removed/Changed the old "Unknown Building" Checks.
* Change Identifiers and names for Skyscrapers to distinguish the both tiers
* Fixed the Buildings Identifier namechange that resulted in translation statics screen error

Co-authored-by: Sting Mcray <[email protected]>
Co-authored-by: FroggieFrog <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
anno 1800 changes or issues affecting features relating to Anno 1800 enhancement New feature or request PresetParser Features or issues relationg to the PresetParser.
Projects
None yet
Milestone
Anno Designer 9.2 Release
Development

Successfully merging a pull request may close this issue.

Update Preset Parser and Presets.json
1 participant
@StingMcRay