Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocked harbor area can now be shown on canvas (#323) #354

Merged
merged 9 commits into from
Sep 14, 2021
Merged

Blocked harbor area can now be shown on canvas (#323) #354

merged 9 commits into from
Sep 14, 2021

Conversation

Atria1234
Copy link
Collaborator

@Atria1234 Atria1234 commented Sep 9, 2021 •
edited by StingMcRay
Loading

TODOs:

  • Add unit tests for new properties
  • Update presets with new properties (Direction, BlockedArea)

@StingMcRay
Copy link
Contributor

The preset changes will be in an other PR to avoid problems i have with Githib or Git....
The 3 files that are committed by me in this PR may be deleted (if that is possible)

@StingMcRay StingMcRay mentioned this pull request Sep 11, 2021
Merged
@Atria1234
Copy link
Collaborator Author

The 3 files that are committed by me in this PR may be deleted (if that is possible)

There are no files commited by you in this PR

@StingMcRay
Copy link
Contributor

The 3 files that are committed by me in this PR may be deleted (if that is possible)

There are no files commited by you in this PR

afbeelding
this is what i see :D

@Atria1234
Copy link
Collaborator Author

obrazek
but this repository is Atria1234/anno-designer, but you still referenced same issue, so it is linked here

@StingMcRay
Copy link
Contributor

Then i hope nothing will go wrong on Merging :)

@StingMcRay
Copy link
Contributor

The Preset Parser and Presets.json to use this new feature and other updates are in PR #356
Merge this PR first before merging PR #356

@FroggieFrog FroggieFrog added this to the Anno Designer 9.2 Release milestone Sep 13, 2021
@FroggieFrog FroggieFrog merged commit 896548a into AnnoDesigner:master Sep 14, 2021
@FroggieFrog
Copy link
Collaborator

Thank you for this great and quick contribution! 👍

@Atria1234 Atria1234 deleted the feature/show-blocked-harbor-area branch September 14, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StingMcRay StingMcRay StingMcRay left review comments

@FroggieFrog FroggieFrog FroggieFrog left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Anno Designer 9.2 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@Atria1234 @StingMcRay @FroggieFrog