[1.0.1 -> main] Log calculated LIB for deep-mind #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…B of the node for deep-mind. Also avoid accessing the forkdb during replay.
… is available via is_valid(). Do not require root to be available.
[1.0.1] Log calculated LIB for deep-mind
linh2931
approved these changes
Sep 10, 2024
greg7mdp
approved these changes
Sep 10, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the deep-mind log, log the caculated LIB instead of the node's realized LIB. This more closely reflects legacy behavior and is more appropriate for deep-mind logging as it cares more about the state of the chain than any particular node.
Also adds debug
asserts to all forkdb calls that expect fork databaserootto exist.Merges
release/1.0intomainincluding #731Resolves #728