API review feedback (#1239)

App-vNext · Jun 1, 2023 · cfb9fc0 · cfb9fc0
1 parent b6f8d2b
commit cfb9fc0
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/src/Polly.Core/CircuitBreaker/CircuitBreakerManualControl.cs b/src/Polly.Core/CircuitBreaker/CircuitBreakerManualControl.cs
@@ -40,7 +40,7 @@ internal void Initialize(Func<ResilienceContext, Task> onIsolate, Func<Resilienc
     /// <exception cref="ArgumentNullException">Thrown when <paramref name="context"/> is <see langword="null"/>.</exception>
     /// <exception cref="InvalidOperationException">Thrown when manual control is not initialized.</exception>
     /// <exception cref="ObjectDisposedException">Thrown when calling this method after this object is disposed.</exception>
-    public Task IsolateAsync(ResilienceContext context)
+    internal Task IsolateAsync(ResilienceContext context)
     {
         Guard.NotNull(context);
 
@@ -83,7 +83,7 @@ public async Task IsolateAsync(CancellationToken cancellationToken = default)
     /// <exception cref="ArgumentNullException">Thrown when <paramref name="context"/> is <see langword="null"/>.</exception>
     /// <exception cref="InvalidOperationException">Thrown if manual control is not initialized.</exception>
     /// <exception cref="ObjectDisposedException">Thrown when calling this method after this object is disposed.</exception>
-    public Task CloseAsync(ResilienceContext context)
+    internal Task CloseAsync(ResilienceContext context)
     {
         Guard.NotNull(context);
 

diff --git a/src/Polly.Core/Strategy/Outcome.cs b/src/Polly.Core/Strategy/Outcome.cs
@@ -25,7 +25,7 @@ internal Outcome(ExceptionDispatchInfo exceptionDispatchInfo)
     /// Initializes a new instance of the <see cref="Outcome{TResult}"/> struct.
     /// </summary>
     /// <param name="result">The result of the operation.</param>
-    public Outcome(TResult result)
+    public Outcome(TResult? result)
         : this() => Result = result;
 
     /// <summary>

diff --git a/src/Polly.Core/Strategy/PredicateBuilder.cs b/src/Polly.Core/Strategy/PredicateBuilder.cs
@@ -12,6 +12,10 @@ public sealed class PredicateBuilder<TResult>
 {
     private readonly List<Predicate<Outcome<TResult>>> _predicates = new();
 
+    internal PredicateBuilder()
+    {
+    }
+
     /// <summary>
     /// Adds a predicate for handling exceptions of the specified type.
     /// </summary>

diff --git a/src/Polly.Extensions/DependencyInjection/PollyServiceCollectionExtensions.cs b/src/Polly.Extensions/DependencyInjection/PollyServiceCollectionExtensions.cs
@@ -10,7 +10,7 @@
 using Polly.Registry;
 using Polly.Utils;
 
-namespace Microsoft.Extensions.DependencyInjection;
+namespace Polly;
 
 /// <summary>
 /// Provides extension methods for registering resilience strategies using the <see cref="IServiceCollection"/>.