Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API review feedback #1239

Merged
merged 1 commit into from
Jun 1, 2023
Merged

API review feedback #1239

merged 1 commit into from
Jun 1, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented May 30, 2023

Details on the issue fix or feature implementation

Some low-effort changes based on the API review.

#1233

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label May 30, 2023
@martintmk martintmk added this to the v8.0.0 milestone May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #1239 (9efb528) into main (141bd0a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1239   +/-   ##
=======================================
  Coverage   82.91%   82.92%           
=======================================
  Files         262      262           
  Lines        6141     6143    +2     
  Branches      966      966           
=======================================
+ Hits         5092     5094    +2     
  Misses        844      844           
  Partials      205      205           
Flag Coverage Δ
linux 82.92% <100.00%> (+<0.01%) ⬆️
macos 82.92% <100.00%> (+<0.01%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Core/CircuitBreaker/CircuitBreakerManualControl.cs 100.00% <ø> (ø)
src/Polly.Core/Strategy/Outcome.cs 100.00% <ø> (ø)
...dencyInjection/PollyServiceCollectionExtensions.cs 100.00% <ø> (ø)
src/Polly.Core/Strategy/PredicateBuilder.cs 100.00% <100.00%> (ø)

@martintmk martintmk requested a review from martincostello June 1, 2023 07:42
@martintmk
Copy link
Contributor Author

@martincostello I think we can also merge this one as these are some simple non-controversial changes based on the review feedback.

@martintmk martintmk merged commit cfb9fc0 into main Jun 1, 2023
@martintmk martintmk deleted the mtomka/review-feedback branch June 1, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants