Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API review feedback #1239

Merged
merged 1 commit into from
Jun 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Polly.Core/CircuitBreaker/CircuitBreakerManualControl.cs
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ internal void Initialize(Func<ResilienceContext, Task> onIsolate, Func<Resilienc
/// <exception cref="ArgumentNullException">Thrown when <paramref name="context"/> is <see langword="null"/>.</exception>
/// <exception cref="InvalidOperationException">Thrown when manual control is not initialized.</exception>
/// <exception cref="ObjectDisposedException">Thrown when calling this method after this object is disposed.</exception>
public Task IsolateAsync(ResilienceContext context)
internal Task IsolateAsync(ResilienceContext context)
{
Guard.NotNull(context);

Expand Down Expand Up @@ -83,7 +83,7 @@ public async Task IsolateAsync(CancellationToken cancellationToken = default)
/// <exception cref="ArgumentNullException">Thrown when <paramref name="context"/> is <see langword="null"/>.</exception>
/// <exception cref="InvalidOperationException">Thrown if manual control is not initialized.</exception>
/// <exception cref="ObjectDisposedException">Thrown when calling this method after this object is disposed.</exception>
public Task CloseAsync(ResilienceContext context)
internal Task CloseAsync(ResilienceContext context)
{
Guard.NotNull(context);

Expand Down
2 changes: 1 addition & 1 deletion src/Polly.Core/Strategy/Outcome.cs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ internal Outcome(ExceptionDispatchInfo exceptionDispatchInfo)
/// Initializes a new instance of the <see cref="Outcome{TResult}"/> struct.
/// </summary>
/// <param name="result">The result of the operation.</param>
public Outcome(TResult result)
public Outcome(TResult? result)
: this() => Result = result;

/// <summary>
Expand Down
4 changes: 4 additions & 0 deletions src/Polly.Core/Strategy/PredicateBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ public sealed class PredicateBuilder<TResult>
{
private readonly List<Predicate<Outcome<TResult>>> _predicates = new();

internal PredicateBuilder()
{
}

/// <summary>
/// Adds a predicate for handling exceptions of the specified type.
/// </summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
using Polly.Registry;
using Polly.Utils;

namespace Microsoft.Extensions.DependencyInjection;
namespace Polly;

/// <summary>
/// Provides extension methods for registering resilience strategies using the <see cref="IServiceCollection"/>.
Expand Down