Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce samples folder #1295

Merged
merged 8 commits into from
Jun 16, 2023
Merged

Introduce samples folder #1295

merged 8 commits into from
Jun 16, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jun 14, 2023

Details on the issue fix or feature implementation

Closes #1291

  • The samples folder includes completely separate style and formatting rules compared to main solution to be aligned with common .NET guidelines.
  • It builds automatically because the cake script scans all solutions in the repo.
  • Just basic examples, more advanced and detailed ones are in Polly-Samples repo.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #1295 (58b662a) into main (833ad99) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1295   +/-   ##
=======================================
  Coverage   83.28%   83.28%           
=======================================
  Files         263      264    +1     
  Lines        6299     6301    +2     
  Branches      994      997    +3     
=======================================
+ Hits         5246     5248    +2     
  Misses        844      844           
  Partials      209      209           
Flag Coverage Δ
macos ?
windows 83.28% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

@martintmk martintmk marked this pull request as ready for review June 14, 2023 11:02
@martintmk martintmk marked this pull request as draft June 14, 2023 14:13
CHANGELOG.md Outdated Show resolved Hide resolved
samples/Intro/Intro.csproj Outdated Show resolved Hide resolved
@martintmk martintmk marked this pull request as ready for review June 15, 2023 15:26
@martintmk martintmk requested a review from martincostello June 16, 2023 05:28
samples/DependencyInjection/Program.cs Show resolved Hide resolved
samples/Extensibility/Program.cs Show resolved Hide resolved
samples/Extensibility/Program.cs Outdated Show resolved Hide resolved
samples/Extensibility/Program.cs Outdated Show resolved Hide resolved
samples/Extensibility/Program.cs Outdated Show resolved Hide resolved
samples/Intro/Program.cs Outdated Show resolved Hide resolved
samples/Retries/Program.cs Outdated Show resolved Hide resolved
samples/Retries/Program.cs Show resolved Hide resolved
samples/Retries/Program.cs Outdated Show resolved Hide resolved
samples/Retries/Program.cs Outdated Show resolved Hide resolved
samples/Extensibility/Program.cs Outdated Show resolved Hide resolved
samples/Extensibility/Program.cs Outdated Show resolved Hide resolved
samples/Retries/Program.cs Outdated Show resolved Hide resolved
@martincostello
Copy link
Member

Just some outstanding comments for Generic and Intro.

@martintmk martintmk enabled auto-merge (squash) June 16, 2023 09:04
Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@martintmk martintmk merged commit 9506d05 into main Jun 16, 2023
@martintmk martintmk deleted the mtomka/samples branch June 16, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Introduce samples folder
2 participants