fix: no focus border on date cells (#1469)

* fix: no focus border on date cells * fix: remove redundant import * refactor: use existing functionality from GridCellWidget for focus border * refactor: use requestBeginFocus override instead of GestureDetector
AppFlowy-IO · Dec 21, 2022 · 873a46e · 873a46e
1 parent 9a387b2
commit 873a46e
Showing 1 changed file with 11 additions and 12 deletions.
diff --git a/frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_cell.dart b/frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_cell.dart
@@ -70,17 +70,13 @@ class _DateCellState extends GridCellState<GridDateCell> {
             constraints: BoxConstraints.loose(const Size(260, 500)),
             margin: EdgeInsets.zero,
             child: SizedBox.expand(
-              child: GestureDetector(
-                behavior: HitTestBehavior.opaque,
-                onTap: () => _popover.show(),
-                child: Align(
-                  alignment: alignment,
-                  child: Padding(
-                    padding: GridSize.cellContentInsets,
-                    child: FlowyText.medium(
-                      state.dateStr,
-                      overflow: TextOverflow.ellipsis,
-                    ),
+              child: Align(
+                alignment: alignment,
+                child: Padding(
+                  padding: GridSize.cellContentInsets,
+                  child: FlowyText.medium(
+                    state.dateStr,
+                    overflow: TextOverflow.ellipsis,
                   ),
                 ),
               ),
@@ -108,7 +104,10 @@ class _DateCellState extends GridCellState<GridDateCell> {
   }
 
   @override
-  void requestBeginFocus() {}
+  void requestBeginFocus() {
+    _popover.show();
+    widget.onCellEditing.value = true;
+  }
 
   @override
   String? onCopy() => _cellBloc.state.dateStr;