fix: no focus border on date cells #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eakam1007
force-pushed
the
fix-date-cells-border-1414
branch
from
af297c6 to
3458f43
Compare
richardshiue
reviewed
Dec 5, 2022
frontend/app_flowy/lib/plugins/grid/presentation/widgets/cell/date_cell/date_cell.dart
Show resolved
Hide resolved
Eakam1007
requested review from
richardshiue
and removed request for
appflowy
annieappflowy
added
grid
richardshiue
requested changes
Dec 10, 2022
There was a problem hiding this comment.
Hello @Eakam1007, I missed the fact that the GridCellState itself already has a method called requestBeginFocus() that is hooked up to listen for focus changes. You can move those two lines from onTap() to the override implementation below. After doing this, you can also get rid of the GestureDetector so that the immediate child of SizedBox.expand is the Align. Sorry for the mixup
richardshiue
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
LGTM, for real this time. Thanks for contributing @Eakam1007!
LucasXu0
pushed a commit
to LucasXu0/AppFlowy
that referenced
this pull request
Dec 23, 2022
* fix: no focus border on date cells * fix: remove redundant import * refactor: use existing functionality from GridCellWidget for focus border * refactor: use requestBeginFocus override instead of GestureDetector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1414
Added a focus border to date cells if the popup is open: