Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: handle sent to self with return transactions #795

Merged
merged 13 commits into from
Nov 6, 2024
Merged

refactor: handle sent to self with return transactions #795

merged 13 commits into from
Nov 6, 2024

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Nov 4, 2024 •
edited
Loading

Summary

As a part of: https://app.clickup.com/t/86dv3g5de
Should be used to test: ArdentHQ/platform-sdk#106

Note: I'll fix this PR once PSDK changes are released.

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Nov 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Nov 6, 2024 1:53pm

This was referenced Nov 5, 2024
Merged
Merged
@shahin-hq shahin-hq marked this pull request as ready for review November 6, 2024 12:28
@shahin-hq shahin-hq added this to the 1.18.0 milestone Nov 6, 2024
@shahin-hq shahin-hq merged commit 06fdcda into develop Nov 6, 2024
20 checks passed
@shahin-hq shahin-hq deleted the refactor/tx-amount-hint branch November 6, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patricio0312rev patricio0312rev patricio0312rev approved these changes

@goga-m goga-m goga-m approved these changes

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shahin-hq @goga-m @patricio0312rev