refactor: isReturn and total methods
#106
Conversation
…a' into refactor/confirmed-signed-tx-data
| } | ||
| } | ||
|
|
||
| return isReturn; |
There was a problem hiding this comment.
This change ensures that isReturn will return true only when all of the recipients are the same as sender.
|
|
||
| return isReturn; | ||
| } | ||
|
|
There was a problem hiding this comment.
The same as above but for the signed transactions.
There was a problem hiding this comment.
@shahin-hq I think here we could use the this.isReturn() from the signed dto in the coins, or do you see any issues?
There was a problem hiding this comment.
I tried that before but couldn't because I couldn't find a way to access given wallet in coin class.
| @@ -131,11 +148,25 @@ export class ExtendedSignedTransactionData { | |||
| } | |||
|
|
|||
| public total(): number { | |||
| if (this.isReturn()) { | |||
| return this.amount() - this.fee(); | |||
| } | |||
There was a problem hiding this comment.
If a transaction is a returning the fee should be subtracted
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Added total calculation for multipayment signed transactions. The same as confirmed transaction:
Closes: https://app.clickup.com/t/86dv3g5de
For testing: ArdentHQ/arkvault#795