Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sent to self label #801

Merged
merged 1 commit into from
Nov 7, 2024
Merged

fix: sent to self label #801

merged 1 commit into from
Nov 7, 2024

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Nov 7, 2024

Closes: https://app.clickup.com/t/86dv45qqz

Summary

Multipayment tx: A is sender, A and B are receivers

A POV: DErsBi7QDiqxj6jh5C5VgK3qaksQbkG6F9, Received 1 DARK
image

B POV: DKM6QNS5bLggQmUbtpXiARCgjvwhXGNq4Z, Received 0.5 DARK
image


Multipayment tx: A is sender, B and C are receivers

A POV: DErsBi7QDiqxj6jh5C5VgK3qaksQbkG6F9

image

B POV: DKM6QNS5bLggQmUbtpXiARCgjvwhXGNq4Z Received 0.1 DARK
image

C POV: DG251q3GRUzTsS6FGrx5tZrEhG8C4iVWVS Received 0.1 DARK
image


Multipayment tx: A is sender, A and A are receivers

A POV: DErsBi7QDiqxj6jh5C5VgK3qaksQbkG6F9
image


Single transfer tx: A is sender, A is receiver
image


Single transfer tx: A is sender, B is receiver
A POV: DErsBi7QDiqxj6jh5C5VgK3qaksQbkG6F9
image

B POV: DKM6QNS5bLggQmUbtpXiARCgjvwhXGNq4Z, Received 0.5 DARK
image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Nov 7, 2024 1:12pm

@shahin-hq shahin-hq merged commit 835e154 into develop Nov 7, 2024
39 checks passed
@shahin-hq shahin-hq deleted the fix/sent-to-self-label branch November 7, 2024 14:38
@ItsANameToo ItsANameToo added this to the 1.18.0 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants