Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: enable hints for multipayments on transaction summary modal #803

Merged
merged 21 commits into from
Nov 18, 2024
Merged

refactor: enable hints for multipayments on transaction summary modal #803

merged 21 commits into from
Nov 18, 2024

Conversation

patricio0312rev
Copy link
Contributor

@patricio0312rev patricio0312rev commented Nov 7, 2024 •
edited
Loading

[tx details] add "send to self" to tx details for multipay transactions

Summary

  • TransactionAmountLabel has been implemented in TransactionSummary modal to display the amounts with hints in case of multipayments.
  • Transaction mocks in unit tests have been refactored to support isReturn and total properties
  • Snapshots have been updated
image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Nov 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Nov 18, 2024 4:36am

@patricio0312rev patricio0312rev mentioned this pull request Nov 7, 2024
Closed
6 tasks
@patricio0312rev patricio0312rev added this to the 1.18.0 milestone Nov 7, 2024
@patricio0312rev
Copy link
Contributor Author

Waiting on #801 to be merged to prevent issues with snapshots

@patricio0312rev patricio0312rev marked this pull request as draft November 7, 2024 14:14
@shahin-hq
Copy link
Contributor

Thanks @patricio0312rev, it is merged!

@patricio0312rev patricio0312rev marked this pull request as ready for review November 7, 2024 16:14
@ItsANameToo ItsANameToo modified the milestones: 1.18.0, 1.19.0 Nov 11, 2024
@ItsANameToo ItsANameToo marked this pull request as draft November 14, 2024 10:06
@patricio0312rev patricio0312rev marked this pull request as ready for review November 14, 2024 13:55
@ItsANameToo ItsANameToo marked this pull request as draft November 18, 2024 03:17
@ItsANameToo
Copy link
Contributor

Please improve the PR title to reflect the changes in the PR @patricio0312rev

@patricio0312rev patricio0312rev changed the title refactor: implement transaction summary on details refactor: enable hints for multipayments on transaction summary modal Nov 18, 2024
@patricio0312rev
Copy link
Contributor Author

@ItsANameToo done 🌟

@patricio0312rev patricio0312rev marked this pull request as ready for review November 18, 2024 04:36
@patricio0312rev patricio0312rev merged commit 89d8c0d into develop Nov 18, 2024
27 of 39 checks passed
@patricio0312rev patricio0312rev deleted the refactor/implement-transaction-summary-on-details branch November 18, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samharperpittam samharperpittam samharperpittam approved these changes

@goga-m goga-m goga-m approved these changes

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.
5 participants
@patricio0312rev @shahin-hq @ItsANameToo @goga-m @samharperpittam