-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: enable address options when multiple addresses selected #934
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… into refactor/enable-address-options
… into refactor/enable-address-options
// } | ||
|
||
const walletsWithValidatorActions = wallets.filter( | ||
(w) => w.balance() > 0 && !isMultiSignature(w) && isRestoredAndSynced(w), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am filtering out wallets with the given checks, otherwise it'd throw an error when checking w.isValidator()
- it has to be synced before this check
const isWalletRestoredAndSynced = useMemo(() => isRestoredAndSynced(wallet), [wallet]); | ||
const areWalletsRestoredAndSynced = useMemo( | ||
() => wallets.map((wallet) => isRestoredAndSynced(wallet)).join("-"), | ||
[wallets], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to implement such workaround to get the same behavior as it was. This will generate a primitive true-false-true
and we will pass it to dependency array.
… into refactor/enable-address-options
Summary
Closes some part of: https://app.clickup.com/t/86dvv87dm
Changelog:
Screencast.from.2025-02-03.17-06-15.webm
Checklist