-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: enable address options when multiple addresses selected #934
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
0705644
refactor: enable address options when multiple addresses selected
shahin-hq b57d5a0
Merge branch 'feat/evm' into refactor/enable-address-options
shahin-hq 53f87ce
refactor: enable address options when multiple addresses selected
shahin-hq 94a8445
refactor: enable address options when multiple addresses selected
shahin-hq ead140e
style: resolve style guide violations
shahin-hq 43a1a99
refactor: enable address options when multiple addresses selected
shahin-hq 912b480
refactor: enable address options when multiple addresses selected
shahin-hq 430ad58
refactor: validator registration
shahin-hq dfc91f1
Merge branch 'feat/evm' into refactor/enable-address-options
shahin-hq 3bc166e
refactor: validator registration
shahin-hq b9ffeb9
Merge remote-tracking branch 'origin/refactor/enable-address-options'…
shahin-hq a75c413
refactor: validator registration
shahin-hq 255293a
refactor: validator registration
shahin-hq 486c14e
style: resolve style guide violations
shahin-hq 505595d
refactor: validator registration
shahin-hq ad19545
Merge remote-tracking branch 'origin/refactor/enable-address-options'…
shahin-hq 1efae28
style: resolve style guide violations
shahin-hq 712cbcb
refactor: validator registration
shahin-hq 7d26ad8
style: resolve style guide violations
shahin-hq 2fa88a6
refactor: validator registration
shahin-hq e3d6465
Merge remote-tracking branch 'origin/refactor/enable-address-options'…
shahin-hq 7a509e4
style: resolve style guide violations
shahin-hq 70b2952
refactor: add tests
shahin-hq dd97f78
refactor: add tests
shahin-hq 4c9285b
Merge branch 'feat/evm' into refactor/enable-address-options
shahin-hq 65125c8
style: resolve style guide violations
shahin-hq 3c55ebd
wip
shahin-hq b8d65fa
Merge remote-tracking branch 'origin/refactor/enable-address-options'…
shahin-hq f823a59
refactor: enable validator resignation in multiple-address view
shahin-hq efb48c9
refactor: enable validator resignation in multiple-address view
shahin-hq b61fb89
Merge branch 'feat/evm' into refactor/enable-address-options
shahin-hq 58e6f77
wip
shahin-hq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,11 @@ export const TransactionRoutes: RouteItem[] = [ | |
exact: true, | ||
path: ProfilePaths.SendRegistration, | ||
}, | ||
{ | ||
component: SendRegistration, | ||
exact: true, | ||
path: ProfilePaths.SendValidatorRegistrationProfile, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. New route item to handle validator registration without a selected |
||
}, | ||
{ | ||
component: SendValidatorResignation, | ||
exact: true, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the registration form is a wrapper for both musig and validator registration forms, when we have multiple wallets we don't know the selected wallet, this forced me to loosen types, since we haven't touched anything related to musig I ended up adding
assert
to please linter.