Add the SULILGH7 flight controller board #29209
Conversation
|
needs readme and images/pinout....ala https://github.com/ArduPilot/ardupilot/tree/master/libraries/AP_HAL_ChibiOS/hwdef/AET-H743-Basic |
|
I will add some images and descriptions. |
There was a problem hiding this comment.
LGTM
I think @andyp1per would suggest trying to make at least four PWM outputs bi-directional DShot...
|
should be two commits:There should be only the Tools:add SULIGH7-P1-P2 commit and a hwdef:add SULIGH7-P1-P2 commit. |
Do I need to separate the changes in the Tools folder and the hwdef file into two pull requests? |
|
no, just two commits in this PR...I can do it for you tomorrow (I need to make a video on how to do this....many new contributors don't understand)...I will use your PR for the video how to... |
OK（After the video is made, please let me know the source of the video so I can learn from it） |
|
I see, so only two submissions are needed, right? |
|
correct ..here is the video I made https://www.youtube.com/watch?v=iMUWQUD_Rsg |
|
@Hwurzburg What issues remain with this, and when can it be merged? |
|
@andypiper please review before DECALL so this can be merged or modiffied |
Wasn't done, bumping to DevCallEU |
| @@ -0,0 +1,112 @@ | |||
| # SULILGH7P1/P2 Flight Controller | |||
|
|
|||
| # Our firmware will be compatible with SULILGH7-P1 and SULILGH7-P2. | |||
There was a problem hiding this comment.
Should say "This firmware is compatible with ..."
|
|
||
| # Our firmware will be compatible with SULILGH7-P1 and SULILGH7-P2. | ||
|
|
||
| Got it! Here is the link to your open-source hardware: https://oshwhub.com/shuyedeye/p1-flight-control. Let me know if you need assistance with anything else related to your project! |
There was a problem hiding this comment.
Not sure what this is saying
| APJ_BOARD_ID AP_HW_SULILGH7-P1-P2 | ||
|
|
||
| # bootloader is installed at zero offset | ||
| FLASH_RESERVE_START_KB 0 |
There was a problem hiding this comment.
The README claims it is running at 480Mhz, but this is not true unless you add
MCU_CLOCKRATE_MHZ 480
| env USE_ALT_RAM_MAP 1 | ||
|
|
||
| env OPTIMIZE -O2 | ||
|
|
There was a problem hiding this comment.
The README claims it is running at 480Mhz, but this is not true unless you add
MCU_CLOCKRATE_MHZ 480
| # ChibiOS system timer | ||
| STM32_ST_USE_TIMER 2 | ||
|
|
||
| env OPTIMIZE -Os |
There was a problem hiding this comment.
This is the default - remove
|
|
||
| define HAL_LED_ON 0 | ||
|
|
||
| #define HAL_USE_EMPTY_STORAGE 1 |
There was a problem hiding this comment.
remove these two lines, no need in bootloader
| PC3 EXT2_CS CS | ||
|
|
||
| # PWM output pins | ||
| PI0 TIM5_CH4 TIM5 PWM(1) GPIO(50) |
There was a problem hiding this comment.
Probably want BIDIR on PWM1 and PWM3
| PF9 TIM14_CH1 TIM14 GPIO(77) ALARM | ||
|
|
||
| # RC input | ||
| PI5 TIM8_CH1 TIM8 RCININT PULLDOWN LOW |
There was a problem hiding this comment.
What about RCIN on iomcu? Is that not connected?
No description provided.