Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve output files #320

Open
rs028 opened this issue Aug 6, 2018 · 5 comments
Open

Improve output files #320

rs028 opened this issue Aug 6, 2018 · 5 comments

Comments

@rs028
Copy link
Collaborator

rs028 commented Aug 6, 2018

  • instantaneousRates: change name to reactionRates (solved by Rename instananeousRates globally to reactionRates. #349) add column with reaction number, add header

  • lossRates.output and productionRates.output: the current "3D" format is awkward to use. Consider dropping some columns, reformat as "flat" 2D matrix. This may be difficult if the species of interests are 2 or more. Consider multiple files for each species of interest.

  • speciesConcentrations.output: currently limited to 100 species. an MCM model can involve thousands of species, but that would make the file very large and a bit unwieldy.

  • initialConditionsSetting.output: it's unclear what this is and its purpose. It can get very big (hundred of MB).

  • errors.output: make this more useful, maybe convert to a more general log file. Currently, most of the messages are printed to screen (or redirected to the atchem2_error.log file by the HPC system).

  • consider switch to binary formats for output files (for example, netcdf). This has advantages and disadvantages.

@spco
Copy link
Collaborator

spco commented Aug 9, 2018

The extra column and header from (1) are implemented by #327 and #328

@rs028
Copy link
Collaborator Author

rs028 commented Aug 9, 2018

Cool. For point (2) I am not really sure what is the best approach, but I would leave it for now. I think the testing and numerical stuff should have priority.

@rs028 rs028 changed the title output of reaction rates Improve of output files Aug 15, 2018
@rs028 rs028 changed the title Improve of output files Improve output files Aug 15, 2018
@rs028
Copy link
Collaborator Author

rs028 commented Dec 28, 2018

Note: the headers of model/output/lossRates.output and model/output/productionRates.output miss one column

@spco
Copy link
Collaborator

spco commented Jan 2, 2019

Note: the headers of model/output/lossRates.output and model/output/productionRates.output miss one column

This is addressed by #366

@spco
Copy link
Collaborator

spco commented Feb 6, 2019

initialConditionsSetting.output is removed by #379

@rs028 rs028 moved this to Minor Improvements in Roadmap Sep 22, 2022
@rs028 rs028 added this to Roadmap Sep 22, 2022
@rs028 rs028 added this to the version 1.4 milestone Oct 6, 2022
@rs028 rs028 modified the milestones: version 1.4, version 1.5 Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Minor Improvements
Development

No branches or pull requests

2 participants