Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add header and reaction numbers to instantaneous rates files. #327

Merged
merged 1 commit into from
Aug 9, 2018

Conversation

spco
Copy link
Collaborator

@spco spco commented Aug 9, 2018

No description provided.

@codecov
Copy link

codecov bot commented Aug 9, 2018

Codecov Report

Merging #327 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
+ Coverage   89.31%   89.32%   +<.01%     
==========================================
  Files          13       13              
  Lines        1919     1920       +1     
==========================================
+ Hits         1714     1715       +1     
  Misses        205      205
Flag Coverage Δ
#build 65.19% <100%> (+0.02%) ⬆️
#tests 88.85% <100%> (ø) ⬆️
#unittests 25.98% <0%> (-0.02%) ⬇️
Impacted Files Coverage Δ
src/outputFunctions.f90 87.91% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d221ec...eae95ea. Read the comment docs.

@spco spco merged commit bb0225c into AtChem:master Aug 9, 2018
@spco spco deleted the inst_rates branch August 9, 2018 10:06
@rs028
Copy link
Collaborator

rs028 commented Aug 9, 2018

@spco not that it matters, but why does it put so much space before the numbers?

@spco
Copy link
Collaborator Author

spco commented Aug 9, 2018

Because I forgot to strip out the leading whitespace! I'll push out a fix for that.

@rs028
Copy link
Collaborator

rs028 commented Aug 9, 2018

ah okay, I thought I was misunderstanding the code :)
if you are making changes to that I have another suggestion. For clarity I think that if the header is reaction number : reaction rate than we want the : separating the numbers as well. Alternatively, blank space is fine, but then I woul dremove the : from the header.

@spco
Copy link
Collaborator Author

spco commented Aug 9, 2018

I ummed and ahed about this for a while. If I use a whitespace in the header, then it just says

reaction number reaction rate

which is not very clear. I don't particularly like

reactionNumber reactionRate

but at least that would be clearer, and more consistent with other output files.

I'd caution against sticking a : in each line - that is just going to make it more difficult to parse the data into any plotting program. I think this leads into a larger discussion about what format is best to output into - better to output in a useful form than ask users to write complicated code just to wrangle information out of the data format.

I'm happy to move to
reactionNumber reactionRate
for now if you like, as that's consistent. The larger discussion is definitely for the future.

@rs028
Copy link
Collaborator

rs028 commented Aug 9, 2018

Okay I see your point. Let's do reactionNumber reactionRate for now. Eventually, I want to think about how to have better output. I feel the space delimited text files may be a bit limiting as a format.

@spco
Copy link
Collaborator Author

spco commented Aug 9, 2018

Handled by #328

@spco spco mentioned this pull request Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants