Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the use of initialConditionsSetting.output #379

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

spco
Copy link
Collaborator

@spco spco commented Feb 1, 2019

This file is now redundant - it was really just for debug when we were less confident in the behaviour. As we don't see any problems now, there's no reason to keep the file.

@spco
Copy link
Collaborator Author

spco commented Feb 1, 2019

Addresses part of #320

@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #379 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
- Coverage   90.28%   90.26%   -0.02%     
==========================================
  Files          15       15              
  Lines        2121     2117       -4     
==========================================
- Hits         1915     1911       -4     
  Misses        206      206
Flag Coverage Δ
#build 65.24% <ø> (-0.08%) ⬇️
#tests 89.6% <ø> (-0.02%) ⬇️
#unittests 34.67% <ø> (-0.03%) ⬇️
Impacted Files Coverage Δ
src/atchem2.f90 91.42% <ø> (-0.07%) ⬇️
src/inputFunctions.f90 86.91% <ø> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867b263...adbc3e3. Read the comment docs.

@spco spco merged commit 953c342 into AtChem:master Feb 6, 2019
@spco spco mentioned this pull request Feb 6, 2019
@spco spco deleted the remove_initialSettingsOutput branch February 6, 2019 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant