Add placeholder for alt text input field (#530)

Automattic · Jan 14, 2025 · a8060db · a8060db
1 parent ddebd75
commit a8060db
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 1 deletion.
diff --git a/.../com.gravatar.quickeditor.ui.alttext.AltTextPageTest.emptyAltTextPageLoaded.png b/.../com.gravatar.quickeditor.ui.alttext.AltTextPageTest.emptyAltTextPageLoaded.png
diff --git a/....gravatar.quickeditor.ui.alttext.AltTextPageTest.emptyAltTextPageLoadedDark.png b/....gravatar.quickeditor.ui.alttext.AltTextPageTest.emptyAltTextPageLoadedDark.png
diff --git a/gravatar-quickeditor/src/main/java/com/gravatar/quickeditor/ui/alttext/AltTextPage.kt b/gravatar-quickeditor/src/main/java/com/gravatar/quickeditor/ui/alttext/AltTextPage.kt
@@ -208,6 +208,14 @@ internal fun AltTextPage(
                                 Box(
                                     modifier = Modifier.weight(1f),
                                 ) {
+                                    if (altTextState.altText.isEmpty()) {
+                                        Text(
+                                            text = stringResource(
+                                                R.string.gravatar_qe_avatar_alt_text_section_placeholder,
+                                            ),
+                                            color = MaterialTheme.colorScheme.onSurfaceVariant,
+                                        )
+                                    }
                                     innerTextField()
                                 }
                                 Text(

diff --git a/gravatar-quickeditor/src/main/res/values/strings.xml b/gravatar-quickeditor/src/main/res/values/strings.xml
@@ -70,6 +70,6 @@
     <string name="gravatar_qe_avatar_picker_alt_text_update_error">Oops, something didn\'t quite work out while trying to update the alt text.</string>
     <string name="gravatar_qe_avatar_alt_text_section_title">Alt Text</string>
     <string name="gravatar_qe_avatar_alt_text_section_what_is">What is alt text?</string>
-    <string name="gravatar_qe_avatar_alt_text_section_placeholder" tools:ignore="UnusedResources">Write alt text</string>
+    <string name="gravatar_qe_avatar_alt_text_section_placeholder">Write alt text…</string>
     <string name="gravatar_qe_avatar_alt_text_save_button">Save</string>
 </resources>