Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alt Text: Add placeholder for alt text input field #530

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

AdamGrzybkowski
Copy link
Contributor

Closes #499

Description

We mentioned in the issue that this might not be that important anymore but with the decorationBox used for the counter it's rather easy to implement so here it is. The placeholder for the alt text input field.

The placholder's copy matches the iOS.

alt_hint.mp4

Testing Steps

  1. Launch the AltTextPage
  2. Remove the whole text
  3. Confirm you see the placeholder
  4. Try to break it.

@AdamGrzybkowski AdamGrzybkowski added Enhance Enhancement [Feature] Gravatar-Quickeditor Gravatar Quick Editor module labels Jan 10, 2025
@AdamGrzybkowski AdamGrzybkowski added this to the 2.3.0 milestone Jan 10, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 10, 2025

📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
App Name Gravatar Demo
Commit5ae17e0
Direct Downloadgravatar-demo-prototype-build-pr530-5ae17e0.apk

Copy link
Contributor

@hamorillo hamorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks really nice!

@AdamGrzybkowski AdamGrzybkowski force-pushed the adam/502_char_count branch 2 times, most recently from cc870a2 to 58cb184 Compare January 14, 2025 11:32
@AdamGrzybkowski AdamGrzybkowski force-pushed the adam/499_alt_text_placeholder branch from e7932e4 to c101fb1 Compare January 14, 2025 11:34
Base automatically changed from adam/502_char_count to trunk January 14, 2025 12:06
@AdamGrzybkowski AdamGrzybkowski force-pushed the adam/499_alt_text_placeholder branch from c101fb1 to 5ae17e0 Compare January 14, 2025 12:06
@AdamGrzybkowski AdamGrzybkowski merged commit a8060db into trunk Jan 14, 2025
17 checks passed
@AdamGrzybkowski AdamGrzybkowski deleted the adam/499_alt_text_placeholder branch January 14, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhance Enhancement [Feature] Gravatar-Quickeditor Gravatar Quick Editor module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick Editor: Alt Text - Improve behaviour on the Alt text input text
3 participants