-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic job details to email notifications #1434
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jom
changed the title
Add basic job details to email notifications
[WIP] Add basic job details to email notifications
Apr 11, 2018
jom
changed the title
[WIP] Add basic job details to email notifications
Add basic job details to email notifications
Apr 11, 2018
jom
force-pushed
the
add/job-details
branch
2 times, most recently
from
April 11, 2018 21:45
ce9887e
to
9022d25
Compare
alexsanford
approved these changes
Apr 12, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! I tested it out, and it works well. 👍
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #672
Builds off of #1422
Changes proposed in this Pull Request:
Refactored a bit of what I just did in Add email styles and header and footer #1436 to ease future complexity with filters and hooks (cdde24f).
Uses new stylesheet functionality from Add email styles and header and footer #1436.
Cleans up new job listing email notification.
Adds
wpjm_get_the_job_categories()
andwpjm_the_job_categories ()
in support of this objective.Testing instructions:
[submit_job_form]
shortcode and verify the admin gets an email with the correct job details.Proposed changelog entry for your changes: