Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic job details to email notifications #1434

Merged
merged 12 commits into from
Apr 12, 2018
Merged

Add basic job details to email notifications #1434

merged 12 commits into from
Apr 12, 2018

Conversation

jom
Copy link
Member

@jom jom commented Apr 11, 2018

Fixes #672
Builds off of #1422

Changes proposed in this Pull Request:

  • Adds basic job details to email notifications. I chose just a few of the fields to put in for now, but we can add more later if desired.

screen shot 2018-04-12 at 11 09 51 am

Testing instructions:

  • Ensure all tests pass.
  • Submit a job listing using the [submit_job_form] shortcode and verify the admin gets an email with the correct job details.

Proposed changelog entry for your changes:

@jom jom added this to the 1.31.0 milestone Apr 11, 2018
@jom jom requested review from alexsanford and donnapep April 11, 2018 14:30
@jom jom force-pushed the add/job-details branch from 6f65ca7 to 6eb4a61 Compare April 11, 2018 14:38
@jom jom removed request for alexsanford and donnapep April 11, 2018 16:34
@jom jom changed the title Add basic job details to email notifications [WIP] Add basic job details to email notifications Apr 11, 2018
@jom jom force-pushed the add/job-details branch from cddcd62 to 5ff8ad7 Compare April 11, 2018 21:24
@jom jom changed the title [WIP] Add basic job details to email notifications Add basic job details to email notifications Apr 11, 2018
@jom jom requested review from alexsanford and donnapep April 11, 2018 21:39
@jom jom force-pushed the add/job-details branch 2 times, most recently from ce9887e to 9022d25 Compare April 11, 2018 21:45
@jom jom force-pushed the add/job-details branch from 5f75ba2 to 22e2bac Compare April 12, 2018 09:21
Copy link
Contributor

@alexsanford alexsanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! I tested it out, and it works well. 👍

@jom jom merged commit e0177be into master Apr 12, 2018
@jom jom deleted the add/job-details branch April 12, 2018 14:04
@jom jom mentioned this pull request Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants