Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add email styles and header and footer #1436

Merged
merged 3 commits into from
Apr 11, 2018
Merged

Add email styles and header and footer #1436

merged 3 commits into from
Apr 11, 2018

Conversation

jom
Copy link
Member

@jom jom commented Apr 11, 2018 •
edited
Loading

Builds off of #1422

I ended up thinking it would be good to at least add the basic foundation for more advanced styling that we can build off of.

Changes proposed in this Pull Request:

  • Adds email header and footer handling.
  • Adds a basic stylesheet and ability to emogrify styles into email HTML (using Woo's example).

@jom jom mentioned this pull request Apr 11, 2018
Merged
@jom jom force-pushed the add/email-header-footer branch from 8f4517e to e5ab998 Compare April 11, 2018 16:33
@jom jom requested review from alexsanford and donnapep April 11, 2018 16:33
@jom jom added this to the 1.31.0 milestone Apr 11, 2018
@jom jom force-pushed the add/email-header-footer branch from e5ab998 to f01a8bb Compare April 11, 2018 16:37
alexsanford
alexsanford approved these changes Apr 11, 2018
View reviewed changes
Copy link
Contributor

@alexsanford alexsanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@jom jom merged commit 322db13 into master Apr 11, 2018
@jom jom deleted the add/email-header-footer branch April 11, 2018 18:52
@jom jom mentioned this pull request Apr 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsanford alexsanford alexsanford approved these changes

@donnapep donnapep Awaiting requested review from donnapep

Assignees
No one assigned
Labels
[Type] Enhancement
Projects
None yet
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jom @alexsanford