Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusts text to be more consistent and fix visual glitch #14643

Merged
merged 2 commits into from
Feb 12, 2020
Merged

Adjusts text to be more consistent and fix visual glitch #14643

merged 2 commits into from
Feb 12, 2020

Conversation

ChaosExAnima
Copy link
Contributor

Fixes #14641.

Changes proposed in this Pull Request:

  • Adjusts button in security settings page when threat is found to be more consistent.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • This is a bugfix.

Testing instructions:

  1. Create security issue for site.
  2. Go to Jetpack -> Settings.
  3. Look at warning for Backups and security scanning, button on upper right.

Before:
Screen Shot 2020-02-11 at 10 46 26 AM

After:
Screen Shot 2020-02-11 at 11 48 17 AM

Proposed changelog entry for your changes:

  • Fixes visual glitch in security settings page.

@ChaosExAnima ChaosExAnima added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Backup & Scan labels Feb 11, 2020
@ChaosExAnima ChaosExAnima added this to the 8.3 milestone Feb 11, 2020
@ChaosExAnima ChaosExAnima requested review from keoshi and a team February 11, 2020 16:50
@ChaosExAnima ChaosExAnima self-assigned this Feb 11, 2020
@ChaosExAnima ChaosExAnima added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Feb 11, 2020
@ChaosExAnima ChaosExAnima requested a review from a team February 11, 2020 16:50
@jeherve jeherve added Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Design Review Design has been added. Needs a review! labels Feb 11, 2020
@jetpackbot
Copy link
Collaborator

jetpackbot commented Feb 11, 2020 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: March 3, 2020.
Scheduled code freeze: February 25, 2020

Generated by 🚫 dangerJS against 6a91ec0

keoshi
keoshi previously approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have a small nitpick, but what you have here is so much better already so it can be merged anytime.

Could we use sentence case (See threats) instead of title case (See Threats)?

Thank you!

@keoshi keoshi removed the [Status] Needs Design Review Design has been added. Needs a review! label Feb 11, 2020
@ChaosExAnima
Copy link
Contributor Author

@felipeelia - Updated. Can you give me a design 👍?

keoshi
keoshi approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for making that change. 🙌

@felipeelia
Copy link
Contributor

@ChaosExAnima looks good to me as well 😂 /joking, I know you've pinged the wrong Filipe. Glad to see this PR is going fine.

@enejb enejb added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 12, 2020
enejb
enejb approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@enejb enejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well. Nice catch!

@ChaosExAnima ChaosExAnima merged commit abb11d4 into master Feb 12, 2020
@ChaosExAnima ChaosExAnima deleted the fix/security-threat-cta branch February 12, 2020 15:21
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 12, 2020
@folletto
Copy link
Contributor

Nice work!

jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: add #14643
1b9c668
jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: 8.3 running changelog (#14642)
8797bea 
* 8.3 release: changelog

* Changelog: add #14516

* Changelog: add #14574

* Bring in changes from 8.2.1 and 8.2.2

* Update stable version

* Bring in 8.2.3 changes

* Changelog: add #14714

* Changelog: add #14639

* Changelog: add #14678

* Changelog: add #14673

* Changelog: add #14687

* Changelog: add #14704

* Changelog: add #14702

* Changelog: add #14541

* Changelog: add #14657

* Changelog: add #14622

* Changelog: add #14582

* Changelog: add #14638

* Changelog: add #14633

* Changelog: add #14571

* Changelog: add #14592

* Changelog: add #14539

* Changelog: add #14514

* Changelog: add #14643

* Changelog: add #14494

* Changelog: add #13739

* Changelog: add #14707

* Changelog: add #14736

* Changelog: add #14706

* Changelog: add #14730

* Changelog: add #14685

* Changelog: add #14727

* Changelog: add #14711

* Changelog: add #14742

* Changelog: add #14746

* Changelog: add #14725

* Changelog: add #13999

* Changelog: add #14740

* Changelog: add #14759

* Changelog: add #14703

* Changelog: add #14753

* Changelog: add #14754

* Changelog: add #14645

* Cahngelog: add #14599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enejb enejb enejb approved these changes

@keoshi keoshi keoshi approved these changes

Assignees

@ChaosExAnima ChaosExAnima

Labels
Admin Page React-powered dashboard under the Jetpack menu [Feature] Backup & Scan [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
8.3
Development

Successfully merging this pull request may close these issues.

Security: Threats Found button has formatting issue
8 participants
@ChaosExAnima @jetpackbot @felipeelia @folletto @enejb @keoshi @jeherve @matticbot