Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twitter Widget: remove deprecated color-link parameter #14742

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Twitter Widget: remove deprecated color-link parameter #14742

merged 1 commit into from
Feb 21, 2020

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Feb 20, 2020

Fixes #14734

Changes proposed in this Pull Request:

Twitter does not respect this parameter anymore, as per this post
https://twittercommunity.com/t/removing-ie11-support-and-custom-link-colors-in-twitter-for-websites/131171

Testing instructions:

  • Start from a Jetpack site where you've enabled the Widgets module
  • Go to Appearance > Customize > Widgets
  • Add a Twitter widget.
  • The color link option should be gone.
  • The border color option should still be there and allow you to enter custom colors.

Proposed changelog entry for your changes:

  • Twitter Widget: remove deprecated link color parameter

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Extra Sidebar Widgets [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 20, 2020
@jeherve jeherve added this to the 8.3 milestone Feb 20, 2020
@jeherve jeherve requested a review from a team February 20, 2020 10:51
@jeherve jeherve self-assigned this Feb 20, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D39122-code before merging this PR. Thank you!

@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: March 3, 2020.
Scheduled code freeze: February 25, 2020

Generated by 🚫 dangerJS against 7656a12

dereksmart
dereksmart approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested pretty well for me

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 21, 2020
@zinigor zinigor merged commit 618d882 into master Feb 21, 2020
@zinigor zinigor deleted the rm/twitter-color-link-param branch February 21, 2020 16:57
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 21, 2020
@jeherve
Copy link
Member Author

jeherve commented Feb 21, 2020

r203214-wpcom

jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: add #14742
5ecb280
jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: 8.3 running changelog (#14642)
8797bea 
* 8.3 release: changelog

* Changelog: add #14516

* Changelog: add #14574

* Bring in changes from 8.2.1 and 8.2.2

* Update stable version

* Bring in 8.2.3 changes

* Changelog: add #14714

* Changelog: add #14639

* Changelog: add #14678

* Changelog: add #14673

* Changelog: add #14687

* Changelog: add #14704

* Changelog: add #14702

* Changelog: add #14541

* Changelog: add #14657

* Changelog: add #14622

* Changelog: add #14582

* Changelog: add #14638

* Changelog: add #14633

* Changelog: add #14571

* Changelog: add #14592

* Changelog: add #14539

* Changelog: add #14514

* Changelog: add #14643

* Changelog: add #14494

* Changelog: add #13739

* Changelog: add #14707

* Changelog: add #14736

* Changelog: add #14706

* Changelog: add #14730

* Changelog: add #14685

* Changelog: add #14727

* Changelog: add #14711

* Changelog: add #14742

* Changelog: add #14746

* Changelog: add #14725

* Changelog: add #13999

* Changelog: add #14740

* Changelog: add #14759

* Changelog: add #14703

* Changelog: add #14753

* Changelog: add #14754

* Changelog: add #14645

* Cahngelog: add #14599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dereksmart dereksmart dereksmart approved these changes

Assignees

@jeherve jeherve

Labels
[Feature] Extra Sidebar Widgets Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
8.3
Development

Successfully merging this pull request may close these issues.

Twitter Timeline Widget: Link color can no longer be customized
5 participants
@jeherve @matticbot @jetpackbot @dereksmart @zinigor