Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: migrate from Travis to GH Actions #17902
Build: migrate from Travis to GH Actions #17902
Changes from all commits
4c6f528
8f6a6de
d8bc65c
faa751b
4e61fbc
962cb6b
de5c3f3
7cd3cce
6c99ac6
8947dc0
2a7472f
fcb880c
e4e425b
911a28f
dcfa4c9
5dd0473
99beab7
f8af305
c42f374
d2c480b
6a31c10
07e4d4b
f8043b9
5f20c20
4e01ee8
af56a42
28f20bf
5fdaf8d
c4591ea
b28acb7
6520533
5626b90
d743427
99f8d4b
44bd2e2
d4b881f
6ff76e4
761a22b
86262b5
1b20a63
dad0cb0
279cbb0
b2a4e9a
0a6acd2
61985d2
90dfcc6
62d5303
ebe04eb
c6e0d48
056a6ef
28363f4
5858684
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's up to you, but I'd recommend moving all the stuff from setup-travis.sh and run-travis.sh in here into this file, or into .github/actions/ that are then called from here.
run-travis.sh, in particular, seems kind of spaghetti-ish and seems like it would be more clear split up into steps.
If you don't want to, that's fine with me but I may well do it in a followup 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, totally! I'll look at what can be done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I'm going to refactor it in a follow-up PR.
This file was deleted.