Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: migrate from Travis to GH Actions #17902

Merged
merged 52 commits into from
Nov 27, 2020
Merged

Build: migrate from Travis to GH Actions #17902

merged 52 commits into from
Nov 27, 2020

Conversation

brbrr
Copy link
Contributor

@brbrr brbrr commented Nov 25, 2020 •
edited
Loading

Changes proposed in this Pull Request:

  • Move Travis jobs into GH Actions
  • Run PHPUnit tests with WP master and previous only single time.
  • Add a workaround for connection tests
  • Fix Masterbar tests ( was broken since Masterbar: Make tests WPCOM-patible #17895)

Jetpack product discussion

p9dueE-2bk-p2

Does this pull request change what data or activity we track or use?

n/a

Testing instructions:

  • Check "Checks" section, make sure all the Travis jobs are there

Proposed changelog entry for your changes:

  • n/a

@brbrr brbrr self-assigned this Nov 25, 2020
@jetpackbot
Copy link

jetpackbot commented Nov 25, 2020 •
edited
Loading

Scheduled Jetpack release: December 1, 2020.
Scheduled code freeze: November 23, 2020

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against 5858684

anomiex
anomiex reviewed Nov 25, 2020
View reviewed changes
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 A few suggestions.

.github/workflows/phpunit.yml Outdated Show resolved Hide resolved
.github/workflows/phpunit.yml Outdated Show resolved Hide resolved
.github/workflows/phpunit.yml Outdated Show resolved Hide resolved
.github/workflows/phpunit.yml Show resolved Hide resolved
.github/workflows/phpunit.yml
export PLUGIN_SLUG=$(basename $(pwd))
export PATH="$HOME/.config/composer/vendor/bin:$HOME/.composer/vendor/bin:$PATH"
./tests/setup-travis.sh
./tests/run-travis.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's up to you, but I'd recommend moving all the stuff from setup-travis.sh and run-travis.sh in here into this file, or into .github/actions/ that are then called from here.

run-travis.sh, in particular, seems kind of spaghetti-ish and seems like it would be more clear split up into steps.

If you don't want to, that's fine with me but I may well do it in a followup 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, totally! I'll look at what can be done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I'm going to refactor it in a follow-up PR.

brbrr and others added 25 commits November 26, 2020 17:17
@brbrr brbrr marked this pull request as ready for review November 27, 2020 12:35
@brbrr brbrr added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Nov 27, 2020
@jeherve jeherve added Actions GitHub actions used to automate some of the work around releases and repository management Unit Tests labels Nov 27, 2020
This was referenced Nov 27, 2020
Closed
Closed
jeherve
jeherve approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to test well. Let's give it a try!

I would agree that it would be nice to consolidate everything in the .github directory later on, it would be nice to clean things up.

@jeherve jeherve added this to the 9.3 milestone Nov 27, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 27, 2020
@brbrr brbrr merged commit aa6511e into master Nov 27, 2020
@brbrr brbrr deleted the try/migrate-travis-to-ghactions branch November 27, 2020 16:23
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Nov 27, 2020
@brbrr brbrr mentioned this pull request Dec 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anomiex anomiex anomiex left review comments

@jeherve jeherve jeherve approved these changes

Assignees

@brbrr brbrr

Labels
Actions GitHub actions used to automate some of the work around releases and repository management Build [Status] Needs Package Release This PR made changes to a package. Let's update that package now. Unit Tests
Projects
None yet
Milestone
9.3
Development

Successfully merging this pull request may close these issues.
5 participants
@brbrr @jetpackbot @jeherve @anomiex @matticbot