-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Pipeline: Refactor CI pipeline files #17933
Conversation
Scheduled Jetpack release: December 10, 2020. Thank you for the great PR description! When this PR is ready for review, please apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the test jobs are running, they're not actually running the tests. See inline comments for details.
I've suggested some pretty significant changes inline. Feel free to disagree, but IMO it'd be better to do more of the work in the workflow yaml files instead of in scripts to take advantage of the Github UI's grouping of steps. That'd get rid of the code-coverage.sh, phpunit.sh, and includes.sh files.
81eba62
to
3527f5e
Compare
@anomiex Thanks for the thorough review! (I think) I addressed all your comments and move away from shell scripts completely. |
We're passing "8.0" rather than "nightly", so look for that. PR #17933 is going to change all that anyway, but it's not quite ready yet.
a6a8340
to
587372a
Compare
Co-authored-by: Brad Jorsch <[email protected]>
f2ef8aa
to
4b017d6
Compare
This is a follow up to GH Actions migration #17902
Changes proposed in this Pull Request:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
n/a
Testing instructions:
Proposed changelog entry for your changes: