Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: Migrate Classic and Instant Search to package #21515

Closed
wants to merge 14 commits into from
Closed

Search: Migrate Classic and Instant Search to package #21515

wants to merge 14 commits into from

Conversation

jsnmoon
Copy link
Contributor

@jsnmoon jsnmoon commented Oct 22, 2021

Changes proposed in this Pull Request:

WIP

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

TBD

@jsnmoon jsnmoon added [Feature] Search For all things related to Search Instant Search [Package] Search Contains core Search functionality for Jetpack and Search plugins labels Oct 22, 2021
@jsnmoon jsnmoon self-assigned this Oct 22, 2021
@jsnmoon jsnmoon requested review from gibrown and a team as code owners October 22, 2021 23:51
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Feature] Extra Sidebar Widgets Unit Tests labels Oct 22, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • 🔴 Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

🔴 Action required: Please edit your PR description and explain what functional changes your PR includes, and why those changes are needed.

🔴 Action required: Please add missing changelog entries for the following projects: projects/packages/search, projects/plugins/search

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: November 2, 2021.
  • Scheduled code freeze: October 25, 2021.

Search plugin:

  • Next scheduled release: December 7, 2021.
  • Scheduled code freeze: November 29, 2021.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 22, 2021
@jsnmoon jsnmoon force-pushed the try/search-package-creation-instant-search branch from f93b537 to 0864ad9 Compare October 26, 2021 00:43
@jsnmoon
Copy link
Contributor Author

jsnmoon commented Nov 3, 2021

Replaced by #21637.

@jsnmoon jsnmoon closed this Nov 3, 2021
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Nov 3, 2021
@jsnmoon jsnmoon deleted the try/search-package-creation-instant-search branch February 15, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibrown gibrown Awaiting requested review from gibrown

Assignees

@jsnmoon jsnmoon

Labels
[Feature] Extra Sidebar Widgets [Feature] Search For all things related to Search [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Status] Blocked / Hold Touches WP.com Files Unit Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsnmoon @matticbot