-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search: Migrate Classic Search, Instant Search, and Customberg to package #21637
Search: Migrate Classic Search, Instant Search, and Customberg to package #21637
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
e96c16e
to
2b7d6aa
Compare
Caution: This PR has changes that must be merged to WordPress.com |
…ve-classic-and-instant-search-to-package
…ve-classic-and-instant-search-to-package
…ve-classic-and-instant-search-to-package
…ve-classic-and-instant-search-to-package
…ve-classic-and-instant-search-to-package
@jeherve, any chance I could trouble you for a review? This PR has been languishing for a couple of weeks now 😅 The bulk of this change relates to moving search products into the standalone package and refactoring their initialization logic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this! 🚢 🔍
Great news! One last step: head over to your WordPress.com diff, D69778-code, and commit it. Thank you! |
Warning: #21690 must be resolved before merging this PR!
Changes proposed in this Pull Request:
This PR moves the following products to the Search package:
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
Testing auto-configuration & Instant Search:
pnpm build
within the Search package directory.Testing Customberg (search configuration interface)
/wp-admin/admin.php?page=jetpack-search-configure
).Testing Classic Search
Also, ensure that
pnpm test
passes within the Search package.