-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instant Search: ensure the hidden overlay doesn't add whitespace to printed pages #22134
Conversation
…ve-classic-and-instant-search-to-package
…ve-classic-and-instant-search-to-package
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described!
Will create a fresh PR branched off |
Fixes https://github.com/Automattic/jpop-issues/issues/7134.
Note: this PR is branched off #21637.
The only confirmed theme that this has happened on is 'Field Guide' but there may be others.
Changes proposed in this Pull Request:
Ensure the search overlay is completely hidden on printed pages.
On certain themes, the overlay's presence can cause blank pages to be added to the printout.
Does this pull request change what data or activity we track or use?
No.
Testing instructions: