Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General: update WP version requirements to WordPress 6.3. #34127

Merged
merged 2 commits into from
Nov 15, 2023
Merged

General: update WP version requirements to WordPress 6.3. #34127

merged 2 commits into from
Nov 15, 2023

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Nov 14, 2023

Proposed changes:

WordPress 6.4 is out, we can now require WP-1, i.e. WP 6.3.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Primary issue: #32865

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Is CI happy?

@jeherve
General: update WP version requirements to WordPress 6.3.
a561022 
WordPress 6.4 is out, we can now require WP-1, i.e. WP 6.3.

Primary issue: #32865
@jeherve jeherve self-assigned this Nov 14, 2023
@jeherve jeherve mentioned this pull request Nov 14, 2023
Merged
3 tasks
@jeherve jeherve enabled auto-merge (squash) November 14, 2023 18:46
@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Nov 14, 2023
@jeherve jeherve mentioned this pull request Nov 14, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2023 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/wp-requirements-63 branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/wp-requirements-63

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Inspect [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Migration [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] Super Cache A fast caching plugin for WordPress. [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Tools] Development CLI The tools/cli to assist during JP development. Actions GitHub actions used to automate some of the work around releases and repository management labels Nov 14, 2023
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for December 5, 2023 (scheduled code freeze on November 28, 2023).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Backup plugin:

  • Next scheduled release: December 5, 2023.
  • Scheduled code freeze: November 27, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Search plugin:

  • Next scheduled release: December 5, 2023.
  • Scheduled code freeze: November 27, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Social plugin:

  • Next scheduled release: December 5, 2023.
  • Scheduled code freeze: November 27, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Starter Plugin plugin:

  • Next scheduled release: December 5, 2023.
  • Scheduled code freeze: November 27, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Protect plugin:

  • Next scheduled release: December 5, 2023.
  • Scheduled code freeze: November 27, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Videopress plugin:

  • Next scheduled release: December 5, 2023.
  • Scheduled code freeze: November 27, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Super Cache plugin:

  • Next scheduled release: December 5, 2023.
  • Scheduled code freeze: November 27, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Migration plugin:

  • Next scheduled release: December 5, 2023.
  • Scheduled code freeze: November 27, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Inspect plugin:

  • Next scheduled release: December 5, 2023.
  • Scheduled code freeze: November 27, 2023.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

anomiex
anomiex reviewed Nov 14, 2023
View reviewed changes
.phpcs.config.xml
<config name="minimum_supported_wp_version" value="6.2" />
<config name="testVersion" value="5.6-"/>
<config name="minimum_supported_wp_version" value="6.3" />
<config name="testVersion" value="7.0-"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

I'm guessing a separate PR will be for dropping obsolete code paths, but if we're going to do this here then let's go ahead and drop PHP 5 from other places in CI too:

  • jetpack/.github/files/generate-ci-matrix.php

    Lines 71 to 78 in 133f8db

    // PHP 5.6 support was dropped in WP 6.3. Remove this (and everything elsewhere related to PHP 5.6) when we drop support for earlier versions.
    $matrix[] = array(
    'name' => 'PHP tests: PHP 5.6 WP previous',
    'script' => 'test-php',
    'php' => '5.6',
    'wp' => 'previous',
    'timeout' => 20, // 2022-01-25: 5.6 tests have started timing out at 15 minutes. Previously: Successful runs seem to take ~8 minutes for PHP 5.6 and for the 7.4 trunk run, ~5.5-6 for 7.x and 8.0.
    );

  • jetpack/.github/versions.sh

    Line 8 in 133f8db

    MIN_PHP_VERSION=5.6

  • jetpack/.github/workflows/linting.yml

    Line 174 in 133f8db

    php-versions: [ '5.6', '7.0', '7.2', '7.4', '8.0', '8.1', '8.2' ]

Bunch of doc references to 5.6 too:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing a separate PR will be for dropping obsolete code paths,

Yup, doing this in #34126

projects/plugins/backup/readme.txt
@@ -1,7 +1,7 @@
=== Jetpack VaultPress Backup ===
Contributors: automattic, bjorsch, fgiannar, initsogar, jeherve, jwebbdev, kraftbj, macbre, samiff, sermitr, williamvianas
Tags: jetpack, backup, restore
Requires at least: 6.2
Requires at least: 6.3
Requires PHP: 5.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update all these "Requires PHP" lines right away too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping #34126 would get merged before this one, that should help.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

kraftbj
kraftbj approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it!

@jeherve jeherve merged commit d9cad0e into trunk Nov 15, 2023
@jeherve jeherve deleted the update/wp-requirements-63 branch November 15, 2023 16:40
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Nov 15, 2023
anomiex added a commit that referenced this pull request Nov 15, 2023
@anomiex
ci: Remove PHP 5.6 Tests run
9f7035a 
We were going to include this removal in a larger update in #34126,
but #34127 got merged first and broke this test. So let's do this right
away to stop having the failing job in the CI runs.
@anomiex anomiex mentioned this pull request Nov 15, 2023
Merged
3 tasks
anomiex added a commit that referenced this pull request Nov 15, 2023
@anomiex
ci: Remove PHP 5.6 Tests run (#34146)
c56d70d 
We were going to include this removal in a larger update in #34126,
but #34127 got merged first and broke this test. So let's do this right
away to stop having the failing job in the CI runs.
This was referenced Nov 20, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anomiex anomiex anomiex left review comments

@kraftbj kraftbj kraftbj approved these changes

Assignees

@jeherve jeherve

Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Inspect [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Migration [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] Super Cache A fast caching plugin for WordPress. [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Pri] Normal [Tools] Development CLI The tools/cli to assist during JP development. [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeherve @kraftbj @anomiex