Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove PHP 5.6 Tests run #34146

Merged
merged 1 commit into from
Nov 15, 2023
Merged

ci: Remove PHP 5.6 Tests run #34146

merged 1 commit into from
Nov 15, 2023

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Nov 15, 2023

Proposed changes:

We were going to include this removal in a larger update in #34126, but #34127 got merged first and broke this test. So let's do this right away to stop having the failing job in the CI runs.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Is CI happy?

We were going to include this removal in a larger update in #34126,
but #34127 got merged first and broke this test. So let's do this right
away to stop having the failing job in the CI runs.
@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] High labels Nov 15, 2023
@anomiex anomiex requested review from kraftbj, jeherve and a team November 15, 2023 18:36
@anomiex anomiex self-assigned this Nov 15, 2023
@anomiex anomiex enabled auto-merge (squash) November 15, 2023 18:36
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Nov 15, 2023
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@anomiex anomiex merged commit c56d70d into trunk Nov 15, 2023
@anomiex anomiex deleted the remove/php-5.6-from-CI-Tests branch November 15, 2023 18:56
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Pri] High [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants