WooCommerce errors: cannot create a manual order/ see the home dashboard #132
Comments
Robertght
added
[Type] Bug
Robertght
changed the title
|
Support References This comment is automatically generated. Please do not edit it.
|
rickmgithub
added
[Pri] High
Triaged
and removed
[Pri] Low
Needs triage
rickmgithub
moved this from Needs Triage
to Triaged
in Automattic Prioritization: The One Board ™
|
From a cursory glance, this issue may relate to WordPress/wordpress-playground#731. I see what appears to be an extra If that is accurate, upgrading Studio's |
|
The fix is now in |
|
I confirmed that WordPress/sqlite-database-integration#113 resolves this issue.
Thanks for the note, @adamziel! Given Studio's new |
|
In that case, you might need to ask @aristath to publish a new release. |
|
v2.1.11 released 👍 |
|
It appears my follow up testing was completed a bit too hastily. I did not have the MailPoet plugin activated. When MailPoet is deactivated, WooCommerce order creation works as expected. When MailPoet is activated, the first error reported in the issue description still occurs. I also see the below error message atop WP Admin pages.
Expanded SQL errorThis issue also occurs in Playground sites outside of Studio. It appears there may be lingering incompatibility between |
|
Ideally, MailPoet would check the type of db used and then use the corresponding driver for that… They use doctrine-dbal which is an amazing database abstraction layer, but they are forcing MySQL there, and bypassing the WP database system altogether. |
|
Actually, Playground could ship a MySQL to SQLite proxy and support every possible way of connecting to MySQL. There are higher priority platform-level issues we'll be working on in the medium term. If this feature is something you'd like to like to get sooner than later, I suggest contributing to core: WordPress/wordpress-playground#1341 Oh, and check in with MailPoet folks first, I vaguely remember they were exploring a migration to $wpdb. |
|
I wanted to confirm the issue with MailPoet happens on the Windows built too and it's quite easy to replicate. Just install and activate WooCommerce and while in the wizard, leave all recommended plugins to be installed and the error will show up right after it's finished. The error For a newcommer, this would be quite the block. |
|
Removing my assignment as I am currently focused on other work. |
|
If I understand correctly, the Studio uses WordPress Playground under the hood, am I right? The current version of MailPoet (4.57.0) needs a PDO connection, and it is not supported by the WP Playground. The good news is that we are currently working on replacing the PDO connection with WPDB (mailpoet/mailpoet#5734). Switching to WPDB should be the first step to enable the MailPoet to run on WP Playground. We already tested the WPDB version with the WP Playground and ran into a couple of issues with SQLite-database-integration that prevented the plugin from running.
After these issue are fixed and WPDB branch is released hopefully the plugin will run 🤞 |
|
@costasovo thanks for testing the plugin and sharing the findings.
Yes, this is correct. |
If this is a while out it might be worth making WooCommerce or Mailpoet detect this issue and either not install or fail gracefully. However.. this feels like it may be a bigger product discussion, there will be other plugins, themes and custom code that expect PDO / mysql libs. Is Studio able to detect and handle these issues more gracefully? Detection could be a mix of code scanning and error log checking, e.g. catching things like: #172, #181 |
|
Some notes while I am testing this:
|
|
@katinthehatsite see mailpoet/mailpoet#5777 and pcNwfB-4c8-p2 |
|
@katinthehatsite @wojtekn With the build from mailpoet/mailpoet#5777, there are indeed no errors on MailPoet activation in WordPress playground. I will move the pull request forward, so the changes on our side get to |
|
Thank you @JanJakes ! |
|
Thanks for moving this forward @JanJakes! Although we have landed the WPDB driver for Doctrine change and it's indeed in the 5.0.1 release I still see the same issue
Can you confirm these errors occur due to the SQLite version we're using at Studio? |
Actually, 5.0.1 was only a cherry-picked fix, so it does not contain the changes. All of them will be released tomorrow in version 5.0.2. You can also use the build from here, if you want to give it a try a bit earlier. |
|
Thanks for pointing me to the correct release file @JanJakes! I did download that 5.0.2 version, and after enabling it I'm betting a fatal screen error: And the logs show this: 
Am I missing something? |
|
@paulopmt1 I was unable to replicate this in WP Playground, so I downloaded Studio, and got this: This is a regression in the sqlite-database-integration that was fixed in WordPress/sqlite-database-integration#156. Is there a way for you to try this with the latest version of the SQLite integration? |
I just checked at the 
I tried downloading the trunk version and replacing the files, but the error remains. As we talked on Slack, you plan to look at it this week, so let me know if I can help. |
|
@paulopmt1 The 2.1.14 version doesn't include WordPress/sqlite-database-integration#156.
There is no 
Please, make sure you create the site first, then update the SQLite plugin to
To clarify, I want to look at another error that is logged during the activation, but doesn't crash the process. The error above seems to be resolved for me with both WP Playground and Studio. If you want to have the SQLite integration tagged, I'm sure someone from the Orbit team will be able to help. MailPoet 5.0.2 was just released, so you can use the official package 🎉 I hope that helps and the Studio will finally be able to run with MailPoet as well 🤞 |
|
Thanks for sharing the details!
For WooCommerce + MailPoet, we're getting a new error now:
The next step you already shared with me: "This looks like an UPDATE or DELETE query with JOIN that SQLite doesn’t support (nor does the plugin). I will try it with WooCommerce too and get these errors fixed this week. Thanks for the report!". Thanks so much for looking at this @JanJakes! |
|
@paulopmt1 I prepared a pull request with the fixes, and there is a build that you can try already. This is likely to be included in the MailPoet release next week. |
|
Applying the trunk SQLite + the recent Mailpoet version worked perfectly @JanJakes. Thanks for fixing it! 
Do we know when we'll have a release of that trunk SQLite? |
|
New version of the SQLite plugin was just released 👍 |
|
Thank you for the fix @JanJakes and for investigation @paulopmt1 ! I tested everything once again and I am not seeing the issue anymore 🥳 |
github-project-automation
bot
moved this from Triaged
to Done 🎉
in Automattic Prioritization: The One Board ™
Quick summary
After creating a new instance with Studio and installing WooCommerce, I'm unable to create manual orders or see the main Woo home dashboard.
Steps to reproduce
What you expected to happen
To be able to create the manual payment order
What actually happened
First, the Woo home dashboard wouldn't load but I saw this error:
Once MailPoet was deactivated, I was able to load the WooCommerce home dashboard, but the Order page wouldn't load. The errors I saw with Debug mode turned on:
Last, but not least, I'm not able to deactivate WooCommerce through the Plugins page once installed.
Impact
Some (< 50%)
Available workarounds?
No and the app is unusable
Platform
Mac Silicon, Mac Intel
Logs or notes
8191986-zd-a8c
The text was updated successfully, but these errors were encountered: